Contrib.social

BookBreadcrumbBuilder needs to always set the route.book_navigation cache context

Open on Drupal.org →
Created on 4 September 2024, 7 months ago
Updated 18 September 2024, 7 months ago

Problem/Motivation

We recently fixed breadcrumb builders in core as they were not consistently adding cache contexts based on the logic in their applies() method. Let's fix this in Book too so that you can get rid of the warning on test runs.

See: 🐛 BreadcrumbBuilder::applies() mismatch with cacheability metadata Active

Steps to reproduce

Watch any test run and spot the warnings.

Proposed resolution

Same fix as core.

Remaining tasks

None, will create MR right away.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024