- Issue created by @traviscarden
- Merge request !250#3471928: Decompose ApiMessageValidator into separate classes for requests and responses again. → (Merged) created by traviscarden
- Assigned to wim leers
- Status changed to Needs review
4 months ago 1:17am 4 September 2024 - 🇺🇸United States traviscarden
Assigning to @Wim Leers for review, since he gave his explicit permission for the change, but I don't know if it has to be him.
- Assigned to traviscarden
- Status changed to Needs work
4 months ago 6:42am 4 September 2024 - Assigned to wim leers
- Status changed to Needs review
4 months ago 11:00am 4 September 2024 - Issue was unassigned.
- Status changed to Needs work
4 months ago 11:07am 4 September 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
One unaddressed nit, and that last commit introduced one more 😅
- Assigned to wim leers
- Status changed to Needs review
4 months ago 6:02pm 4 September 2024 - 🇺🇸United States traviscarden
D'oh! I rushed that last commit out a few minutes before leaving for a day of travel today, and I guess it shows. 😛 I think I've got it now.
- Issue was unassigned.
- Status changed to RTBC
4 months ago 8:06am 5 September 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
There is an accumulating overhead for every additional event subscriber. This affects 100% of requests/responses, and if it’s only for architectural purity, then it’s not worth the overhead IMHO. But I don't feel strongly about this, plus at this early stage, that's essentially premature optimization.
So, deferring to the owner of this part of the codebase, @traviscarden, and RTBC'ing 😊👍
-
wim leers →
committed 91781b3a on 0.x authored by
traviscarden →
Issue #3471928 by traviscarden, wim leers: Decompose ApiMessageValidator...
-
wim leers →
committed 91781b3a on 0.x authored by
traviscarden →
- Status changed to Fixed
4 months ago 8:10am 5 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.
