[1.0.2] Active trail in side_menu's 3rd level

spryah → closed merge request !105

Hi Sorya,

Thanks for the improvement. Let's ship it with the upcoming 1.0.2 release.

However, I am still not conformable with this change:

-

+

{{ title }}

Because P element is not accepting block elements as children, so it is a bit risky for a slot, especially when used with a display builder like layout_builder. Is it mandatory to do?

(Careful, i have rebased your remote branch, you may need to recreate your local branch)

Hello Pierre,
Thank you for your feedback. I understand your concern. Should we set the title as a setting/prop then?

We have 2 solutions:

• title as a setting/prop in a HTML P element
• title as a field/slot in a HTML DIV element

Okay!
Since we need a semantic element, I kept the title inside a <p> tag and set it as a setting/prop.
I also changed its type from text to token but I'm not sure how I can anticipate this kind of information?

I also changed its type from text to token but I'm not sure how I can anticipate this kind of information?

Token is fine. It is a bit confusing in UI Patterns 1.x because token is a data source not a data type, but a UI Patterns Settings plugin is both a data type and a data source.

It will be converted as a string in UI Patterns 2.x

For this issue and the other ones relative to the fields/settings (slots/props) dilemma, we are deciding that:

• We don't switch from slot to prop in the current 1.0.x branch
• We create a distinct issue for 1.1.x branch with the slot to prop switch
• We update the current MR removing the switch from slot to prop and the switch from DIV to P