Contrib.social

Coding Standard issues

Open on Drupal.org →
Created on 2 September 2024, 4 months ago
Updated 4 September 2024, 4 months ago

Problem/Motivation

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/token.install
---------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------
69 | ERROR | [x] No space found before comment text; expected "// $token_info = [];" but found
| | "//$token_info = [];"
70 | ERROR | [x] No space found before comment text; expected "// foreach
| | (module_implements('token_info') as $module) {" but found "//foreach
| | (module_implements('token_info') as $module) {"
73 | ERROR | [ ] Comment indentation error, expected only 2 spaces
76 | ERROR | [ ] Comment indentation error, expected only 2 spaces
77 | ERROR | [ ] Comment indentation error, expected only 4 spaces
78 | ERROR | [ ] Comment indentation error, expected only 6 spaces
79 | ERROR | [ ] Comment indentation error, expected only 8 spaces
85 | ERROR | [ ] Comment indentation error, expected only 2 spaces
90 | ERROR | [ ] Comment indentation error, expected only 2 spaces
92 | WARNING | [x] There must be no blank line following an inline comment
92 | ERROR | [x] No space found before comment text; expected "// }" but found "//}"
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
31 | WARNING | Line exceeds 80 characters; contains 132 characters
----------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/css/jquery.treetable.css
-------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------
6 | ERROR | [x] Blank lines are not allowed in class definitions
13 | ERROR | [x] Blank lines are not allowed in class definitions
18 | ERROR | [x] Blank lines are not allowed in class definitions
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/css/token.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
16 | ERROR | [x] Multiple selectors should each be on a single line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/css/token.treetable.theme.css
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/TokenFieldRender.php
-------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
31 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/TokenInterface.php
----------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------------------------
5 | ERROR | [x] Missing interface doc comment
10 | ERROR | [ ] Missing parameter type
25 | ERROR | [ ] Missing parameter type
27 | ERROR | [ ] Missing parameter type
57 | ERROR | [x] Visibility must be declared on method "getInvalidTokens"
57 | ERROR | [ ] Type hint "array" missing for $tokens
72 | ERROR | [x] Expected 1 blank line after function; 0 found
73 | ERROR | [x] The closing brace for the interface must have an empty line before it
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/TreeBuilderInterface.php
-----------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------
5 | ERROR | [x] Missing interface doc comment
78 | ERROR | [x] Expected 1 blank line after function; 0 found
79 | ERROR | [x] The closing brace for the interface must have an empty line before it
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/Routing/RouteSubscriber.php
--------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------
16 | ERROR | [ ] Missing short description in doc comment
21 | ERROR | [x] Missing function doc comment
64 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: ...home/aly/www/contribuciones/web/modules/contrib/token/src/Controller/TokenDevelController.php
---------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------------
17 | ERROR | [ ] Missing short description in doc comment
22 | ERROR | [ ] Missing short description in doc comment
27 | ERROR | [x] Missing function doc comment
46 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
49 | ERROR | [x] Return comment indentation must be 3 spaces, found 4 spaces
91 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
91 | ERROR | [x] 4 spaces found before inline comment; expected "// foreach ($tree as $token
| | => $token_info) {" but found "// foreach ($tree as $token => $token_info)
| | {"
91 | ERROR | [x] Inline comments must start with a capital letter
92 | WARNING | [ ] Line exceeds 80 characters; contains 125 characters
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
92 | ERROR | [ ] Comment indentation error, expected only 4 spaces
93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
93 | ERROR | [ ] Comment indentation error, expected only 6 spaces
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
95 | WARNING | [x] There must be no blank line following an inline comment
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
95 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
108 | ERROR | [x] Expected 1 blank line after function; 0 found
109 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/Controller/TokenTreeController.php
---------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------
16 | ERROR | [ ] Missing short description in doc comment
21 | ERROR | [x] Missing function doc comment
37 | ERROR | [x] Visibility must be declared on method "outputTree"
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/TokenServiceProvider.php
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
19 | ERROR | [x] Expected 1 blank line after function; 0 found
20 | ERROR | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/TokenEntityMapper.php
--------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------------
17 | ERROR | [ ] Missing short description in doc comment
22 | ERROR | [ ] Missing short description in doc comment
27 | ERROR | [ ] Missing short description in doc comment
32 | ERROR | [x] Missing function doc comment
55 | ERROR | [x] Visibility must be declared on method "getEntityTypeForTokenType"
67 | ERROR | [x] Visibility must be declared on method "getTokenTypeForEntityType"
72 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/TreeBuilder.php
---------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
---------------------------------------------------------------------------------------------------
11 | ERROR | [x] Missing class doc comment
15 | ERROR | [ ] Missing short description in doc comment
20 | ERROR | [ ] Missing short description in doc comment
25 | ERROR | [ ] Missing short description in doc comment
30 | ERROR | [ ] Missing short description in doc comment
42 | ERROR | [x] Missing function doc comment
69 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
134 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
236 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
266 | ERROR | [x] Expected 1 blank line after function; 0 found
267 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/TokenEntityMapperInterface.php
-----------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------
5 | ERROR | [x] Missing interface doc comment
30 | ERROR | [x] Visibility must be declared on method "getEntityTypeForTokenType"
47 | ERROR | [x] Visibility must be declared on method "getTokenTypeForEntityType"
52 | ERROR | [x] Expected 1 blank line after function; 0 found
53 | ERROR | [x] The closing brace for the interface must have an empty line before it
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/Element/TokenTreeTable.php
---------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 9 LINES
---------------------------------------------------------------------------------------------------
15 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [ ] The array declaration extends to column 139 (the limit is 80). The array
| | content should be split up over multiple lines
51 | ERROR | [ ] Missing parameter comment
56 | ERROR | [ ] Type hint "array" missing for $element
100 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes
| | instead
107 | ERROR | [x] Missing function doc comment
111 | ERROR | [x] Missing function doc comment
131 | ERROR | [x] Use null coalesce operator instead of ternary operator.
149 | ERROR | [x] Expected 1 blank line after function; 0 found
150 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: ...ome/aly/www/contribuciones/web/modules/contrib/token/src/Plugin/Derivative/DevelLocalTask.php
---------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------
12 | ERROR | [x] Missing class doc comment
16 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Missing function doc comment
55 | ERROR | [x] Expected 1 blank line after function; 0 found
56 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/src/Token.php
------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
------------------------------------------------------------------------------
86 | ERROR | [ ] Type hint "array" missing for $token_info
103 | ERROR | [x] Use null coalesce operator instead of ternary operator.
114 | ERROR | [x] Use null coalesce operator instead of ternary operator.
125 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
138 | ERROR | [x] Visibility must be declared on method "getInvalidTokens"
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/token.tokens.inc
---------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 8 WARNINGS AFFECTING 21 LINES
---------------------------------------------------------------------------------------------------
117 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
121 | ERROR | [ ] The array declaration extends to column 203 (the limit is 80). The array
| | content should be split up over multiple lines
537 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
549 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
579 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
616 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
715 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
844 | ERROR | [x] Case breaking statements must be followed by a single blank line
847 | ERROR | [x] Case breaking statements must be followed by a single blank line
850 | ERROR | [x] Case breaking statements must be followed by a single blank line
858 | ERROR | [x] Case breaking statements must be followed by a single blank line
971 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
1052 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
1104 | ERROR | [x] Use null coalesce operator instead of ternary operator.
1198 | ERROR | [ ] The array declaration extends to column 122 (the limit is 80). The array
| | content should be split up over multiple lines
1628 | ERROR | [ ] The array declaration extends to column 109 (the limit is 80). The array
| | content should be split up over multiple lines
1721 | ERROR | [x] Use null coalesce operator instead of ternary operator.
1724 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
1885 | ERROR | [x] Use null coalesce operator instead of ternary operator.
1928 | ERROR | [ ] The array declaration extends to column 108 (the limit is 80). The array
| | content should be split up over multiple lines
1928 | ERROR | [ ] The array declaration extends to column 172 (the limit is 80). The array
| | content should be split up over multiple lines
1940 | ERROR | [ ] The array declaration extends to column 104 (the limit is 80). The array
| | content should be split up over multiple lines
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/token.pages.inc
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
6 | ERROR | [x] There must be exactly one blank line after the file comment
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------

FILE: ...ciones/web/modules/contrib/token/tests/modules/token_module_test/token_module_test.tokens.inc
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
4 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.",
| | or "* Implements hook_foo_BAR_ID_bar() for block templates."
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: ...ribuciones/web/modules/contrib/token/tests/modules/token_module_test/token_module_test.module
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
24 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar()
| | for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
---------------------------------------------------------------------------------------------------

FILE: ...e/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/Tree/HelpPageTest.php
---------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
16 | ERROR | [ ] Missing short description in doc comment
26 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/Tree/TreeTest.php
---------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------
17 | ERROR | [ ] Missing short description in doc comment
27 | ERROR | [x] Missing function doc comment
96 | ERROR | [ ] The array declaration extends to column 98 (the limit is 80). The array content
| | should be split up over multiple lines
135 | ERROR | [ ] Type hint "array" missing for $options
145 | ERROR | [x] Expected 1 blank line after function; 0 found
146 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: ...www/contribuciones/web/modules/contrib/token/tests/src/Functional/Tree/TokenTreeTestTrait.php
---------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------
45 | ERROR | [ ] Doc comment short description must be on a single line, further text should be
| | a separate paragraph
65 | ERROR | [ ] Missing parameter type
85 | ERROR | [ ] Missing parameter type
105 | ERROR | [ ] Missing parameter type
120 | ERROR | [x] Expected 1 blank line after function; 0 found
121 | ERROR | [x] The closing brace for the trait must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: ...home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/TokenTestTrait.php
---------------------------------------------------------------------------------------------------
FOUND 18 ERRORS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------------
17 | ERROR | [x] Visibility must be declared on method "assertToken"
17 | ERROR | [x] Missing function doc comment
21 | ERROR | [x] Visibility must be declared on method "assertTokens"
21 | ERROR | [x] Missing function doc comment
31 | ERROR | [ ] The array declaration extends to column 105 (the limit is 80). The array
| | content should be split up over multiple lines
34 | ERROR | [ ] The array declaration extends to column 283 (the limit is 80). The array
| | content should be split up over multiple lines
37 | ERROR | [ ] The array declaration extends to column 233 (the limit is 80). The array
| | content should be split up over multiple lines
44 | ERROR | [x] Visibility must be declared on method "mapTokenNames"
44 | ERROR | [x] Missing function doc comment
52 | ERROR | [x] Visibility must be declared on method "assertNoTokens"
52 | ERROR | [x] Missing function doc comment
58 | ERROR | [ ] The array declaration extends to column 140 (the limit is 80). The array
| | content should be split up over multiple lines
62 | ERROR | [x] Visibility must be declared on method "saveAlias"
62 | ERROR | [x] Missing function doc comment
66 | ERROR | [x] Visibility must be declared on method "saveEntityAlias"
66 | ERROR | [x] Missing function doc comment
74 | ERROR | [x] Visibility must be declared on method "assertPageTokens"
103 | ERROR | [ ] The array declaration extends to column 230 (the limit is 80). The array
| | content should be split up over multiple lines
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/TokenURLTest.php
--------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------
27 | ERROR | [x] Visibility must be declared on method "testURLTokens"
27 | ERROR | [x] Missing function doc comment
27 | ERROR | [ ] Method name "TokenURLTest::testURLTokens" is not in lowerCamel format
48 | ERROR | [x] Expected 1 blank line after function; 0 found
49 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/UrlTest.php
-------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
124 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: ...me/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/TokenFieldUiTest.php
---------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------
19 | ERROR | [ ] Missing short description in doc comment
34 | ERROR | [ ] The array declaration extends to column 123 (the limit is 80). The array
| | content should be split up over multiple lines
101 | ERROR | [x] Missing function doc comment
113 | ERROR | [x] Missing function doc comment
203 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
225 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/TokenUserTest.php
---------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
129 | ERROR | [x] Expected 1 blank line after function; 0 found
130 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: ...home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/TokenBlockTest.php
---------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------
32 | ERROR | [ ] The array declaration extends to column 86 (the limit is 80). The array
| | content should be split up over multiple lines
44 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
80 | ERROR | [x] Expected 1 blank line after function; 0 found
81 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/TokenMenuTest.php
---------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AND 3 WARNINGS AFFECTING 19 LINES
---------------------------------------------------------------------------------------------------
32 | ERROR | [x] Visibility must be declared on method "testMenuTokens"
32 | ERROR | [x] Missing function doc comment
104 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
104 | WARNING | [x] There must be no blank line following an inline comment
104 | ERROR | [x] No space found before comment text; expected "//
| | $this->config('menu.entity.node.' . $node->getType())->set('available_menus',
| | ['main-menu'])->save();" but found "//$this->config('menu.entity.node.' .
| | $node->getType())->set('available_menus', ['main-menu'])->save();"
151 | WARNING | [x] A comma should follow the last multiline array item. Found: 'administer site
| | configuration'
299 | ERROR | [ ] Doc comment short description must be on a single line, further text should
| | be a separate paragraph
301 | ERROR | [x] Visibility must be declared on method "testMultilingualMenu"
393 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
394 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
395 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
396 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
397 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
424 | ERROR | [x] Comment indentation error after - element, expected 5 spaces
424 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
434 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
435 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
440 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
441 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
442 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
447 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
448 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
449 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: ...ly/www/contribuciones/web/modules/contrib/token/tests/src/Functional/TokenCurrentPageTest.php
---------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 8 LINES
---------------------------------------------------------------------------------------------------
19 | ERROR | [x] Visibility must be declared on method "testCurrentPageTokens"
19 | ERROR | [x] Missing function doc comment
32 | ERROR | [ ] The array declaration extends to column 110 (the limit is 80). The array content
| | should be split up over multiple lines
36 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
44 | ERROR | [ ] The array declaration extends to column 99 (the limit is 80). The array content
| | should be split up over multiple lines
53 | ERROR | [ ] The array declaration extends to column 103 (the limit is 80). The array content
| | should be split up over multiple lines
60 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
66 | ERROR | [x] Expected 1 blank line after function; 0 found
67 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/ArrayTest.php
---------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
12 | ERROR | [x] Visibility must be declared on method "testArrayTokens"
12 | ERROR | [x] Missing function doc comment
34 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/NodeTest.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
44 | ERROR | Doc comment is empty
------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/CommentTest.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
49 | ERROR | Doc comment is empty
---------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/LanguageTest.php
-------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
45 | ERROR | Class property $language_prefixes should use lowerCamel naming without underscores
52 | ERROR | Class property $language_domains should use lowerCamel naming without underscores
-------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/UrlTest.php
---------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------
56 | ERROR | [x] list(...) is forbidden, use [...] instead.
81 | ERROR | [ ] The array declaration extends to column 147 (the limit is 80). The array content
| | should be split up over multiple lines
82 | ERROR | [ ] The array declaration extends to column 84 (the limit is 80). The array content
| | should be split up over multiple lines
83 | ERROR | [ ] The array declaration extends to column 117 (the limit is 80). The array content
| | should be split up over multiple lines
84 | ERROR | [ ] The array declaration extends to column 105 (the limit is 80). The array content
| | should be split up over multiple lines
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/FileTest.php
------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
5 | ERROR | [x] There must be one blank line after the last USE statement; 0 found;
26 | ERROR | [x] Visibility must be declared on method "testFileTokens"
26 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/EntityTest.php
--------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------
47 | ERROR | [x] Visibility must be declared on method "testEntityMapping"
47 | ERROR | [x] Missing function doc comment
70 | ERROR | [x] Visibility must be declared on method "addTerm"
70 | ERROR | [x] Missing function doc comment
83 | ERROR | [x] Visibility must be declared on method "testEntityOriginal"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/DateTest.php
------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
------------------------------------------------------------------------------------------
25 | ERROR | [x] Visibility must be declared on method "testDateTokens"
25 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/FieldTest.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
31 | ERROR | Missing short description in doc comment
-------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/TaxonomyTest.php
---------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------
17 | ERROR | Missing member variable doc comment
45 | ERROR | The array declaration extends to column 106 (the limit is 80). The array content
| | should be split up over multiple lines
62 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content
| | should be split up over multiple lines
80 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content
| | should be split up over multiple lines
101 | ERROR | Doc comment is empty
113 | ERROR | Doc comment is empty
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/BookTest.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
40 | ERROR | Doc comment is empty
------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/UnitTest.php
---------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------
12 | ERROR | [ ] Missing short description in doc comment
58 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
88 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/tests/src/Kernel/RandomTest.php
--------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
12 | ERROR | [x] Visibility must be declared on method "testRandomTokens"
12 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: /home/aly/www/contribuciones/web/modules/contrib/token/token.module
---------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 5 WARNINGS AFFECTING 15 LINES
---------------------------------------------------------------------------------------------------
33 | ERROR | [ ] The array declaration extends to column 597 (the limit is 80). The array
| | content should be split up over multiple lines
180 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
218 | WARNING | [ ] The deprecation-version 'token:8.x-1.x' does not match the lower-case
| | machine-name standard: drupal:n.n.n or project:n.x-n.n or
| | project:n.x-n.n-label[n] or project:n.n.n or project:n.n.n-label[n]
218 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it
245 | ERROR | [x] Use null coalesce operator instead of ternary operator.
272 | ERROR | [ ] The array declaration extends to column 177 (the limit is 80). The array
| | content should be split up over multiple lines
402 | ERROR | [ ] Missing parameter type
404 | ERROR | [x] Separate the @param and @return sections by a blank line.
404 | ERROR | [ ] Return type missing for @return tag in function comment
411 | ERROR | [ ] The array declaration extends to column 92 (the limit is 80). The array
| | content should be split up over multiple lines
433 | ERROR | [x] Use null coalesce operator instead of ternary operator.
453 | ERROR | [ ] The array declaration extends to column 81 (the limit is 80). The array
| | content should be split up over multiple lines
558 | ERROR | [x] Missing function doc comment
594 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
706 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
724 | ERROR | [x] Use null coalesce operator instead of ternary operator.
736 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
| | for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block
| | templates."
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇵🇪Peru alyaj2a

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alyaj2a
  • Merge request !80Coding Standard Issues - Closes #3471655 → (Open) created by alyaj2a
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇵🇪Peru alyaj2a
  • Pipeline finished with Failed
    4 months ago
    Total: 149s
    #274029
  • Status changed to Needs work 3 months ago
  • Comment 3 months ago →
    🇵🇭Philippines clarkssquared

    I applied the MR !80 and I can still see PHPCS issues in the module

    ➜  token git:(8.x-1.15) curl https://git.drupalcode.org/project/token/-/merge_requests/80.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 87460    0 87460    0     0   157k      0 --:--:-- --:--:-- --:--:--  159k
patching file README.md
patching file 'src/Controller/TokenDevelController.php'
patching file 'src/Controller/TokenTreeController.php'
patching file 'src/Element/TokenTreeTable.php'
patching file 'src/Plugin/Derivative/DevelLocalTask.php'
patching file 'src/Routing/RouteSubscriber.php'
patching file 'src/Token.php'
patching file 'src/TokenEntityMapper.php'
patching file 'src/TokenEntityMapperInterface.php'
patching file 'src/TokenFieldRender.php'
patching file 'src/TokenInterface.php'
patching file 'src/TokenServiceProvider.php'
patching file 'src/TreeBuilder.php'
patching file 'src/TreeBuilderInterface.php'
patching file 'tests/modules/token_module_test/token_module_test.module'
patching file 'tests/modules/token_module_test/token_module_test.tokens.inc'
patching file 'tests/src/Functional/TokenBlockTest.php'
patching file 'tests/src/Functional/TokenCurrentPageTest.php'
patching file 'tests/src/Functional/TokenFieldUiTest.php'
patching file 'tests/src/Functional/TokenMenuTest.php'
patching file 'tests/src/Functional/TokenTestTrait.php'
patching file 'tests/src/Functional/TokenURLTest.php'
patching file 'tests/src/Functional/TokenUserTest.php'
patching file 'tests/src/Functional/Tree/HelpPageTest.php'
patching file 'tests/src/Functional/Tree/TokenTreeTestTrait.php'
patching file 'tests/src/Functional/Tree/TreeTest.php'
patching file 'tests/src/Functional/UrlTest.php'
patching file 'tests/src/Kernel/ArrayTest.php'
patching file 'tests/src/Kernel/BookTest.php'
patching file 'tests/src/Kernel/CommentTest.php'
patching file 'tests/src/Kernel/DateTest.php'
patching file 'tests/src/Kernel/EntityTest.php'
patching file 'tests/src/Kernel/FieldTest.php'
patching file 'tests/src/Kernel/FileTest.php'
patching file 'tests/src/Kernel/LanguageTest.php'
patching file 'tests/src/Kernel/NodeTest.php'
patching file 'tests/src/Kernel/RandomTest.php'
patching file 'tests/src/Kernel/TaxonomyTest.php'
patching file 'tests/src/Kernel/UnitTest.php'
patching file 'tests/src/Kernel/UrlTest.php'
patching file token.install
patching file token.module
patching file token.pages.inc
patching file token.tokens.inc
➜  token git:(8.x-1.15) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml token 

FILE: ...g-subing/Projects/d10/drupal_local/web/modules/contrib/token/css/token.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | ERROR | [x] Multiple selectors should each be on a single line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/d10/drupal_local/web/modules/contrib/token/css/token.treetable.theme.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: ...ojects/d10/drupal_local/web/modules/contrib/token/css/jquery.treetable.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  6 | ERROR | [x] Blank lines are not allowed in class definitions
 13 | ERROR | [x] Blank lines are not allowed in class definitions
 18 | ERROR | [x] Blank lines are not allowed in class definitions
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ontrib/token/tests/modules/token_module_test/token_module_test.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | WARNING | Open page callback found, please add a comment before the line
   |         | why there is no access restriction
--------------------------------------------------------------------------------


FILE: ...drupal_local/web/modules/contrib/token/tests/src/Kernel/KernelTestBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 5 | ERROR | [x] All trigger_error calls used for deprecation must be prefixed
   |       |     by an "@"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 2.25 secs; Memory: 26MB

➜  contrib git:(main) ✗
  • Pipeline finished with Failed
    3 months ago
    Total: 185s
    #284566
  • Comment 3 months ago →
    🇵🇪Peru alyaj2a

    Hello clarkssquared! , I have fixed the issues you mentioned are still present, and I've already uploaded the changes. However, there's one regarding a CSS file that I'm not sure how to resolve. It's a warning indicating that the file is minified, but it actually isn't. What can we do about this?

    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

    FILE: .../web/modules/contrib/token-3471655/css/token.treetable.theme.css
    --------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------
    1 | WARNING | File appears to be minified and cannot be processed
    --------------------------------------------------------------------------------------------------

  • Comment about 2 months ago →
    🇮🇳India amit.rawat777

    Hi @alyaj2a, I’ll be looking into this issue.

  • Comment about 1 month ago →
    🇧🇷Brazil PabloNicolas

    Hello @alyaj2a and @amit.rawat777

    I had a similar issue before and fixed adding /* phpcs:ignoreFile */ to the beginning of the file. On PHP files we can ignore specific blocks of code but it wasn't possible on CSS. See more at https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignorin....

  • Merge request !85Token-3471655: coding standard issues → (Open) created by PabloNicolas
  • Assigned to amit.rawat777
  • Pipeline finished with Failed
    20 days ago
    Total: 170s
    #358897
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024