Add Smart Date compatibility

Created on 2 September 2024, 9 months ago
Updated 7 September 2024, 9 months ago

Problem/Motivation

This module already includes support for date_recur, so it should also include support for Smart Date fields.

Proposed resolution

Add similar code to support Smart Date fields.

Feature request
Status

Fixed

Version

3.0

Component

Code

Created by

🇨🇦Canada mandclu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mandclu
  • Merge request !7Add Smart Date compatibility → (Merged) created by mandclu
  • Status changed to Needs review 9 months ago
  • 🇨🇦Canada mandclu

    Here is an MR to add Smart Date compatibility. Something to note: The intent here is to use this with view field display setting "Display all values in the same row" turned off, so that only the data required for a given time period can be retrieved and displayed. In this configuration, I see a couple of warnings when the view is first rendered:

    Warning: Undefined property: Drupal\views\ViewExecutable::$row_index in Drupal\views\Plugin\views\field\EntityField->prepareItemsByDelta() (line 743 of core/modules/views/src/Plugin/views/field/EntityField.php).
    
    Warning: Undefined array key "" in Drupal\views\Plugin\views\field\EntityField->prepareItemsByDelta() (line 743 of core/modules/views/src/Plugin/views/field/EntityField.php).

    I suspect these errors have more to do with how this module handles multivalue fields in general, but it warrants more investigation.

  • Pipeline finished with Skipped
    9 months ago
    #276633
    • mandclu committed 75e7dbb3 on 3.0.x
      Issue #3471651 by mandclu: Add Smart Date compatibility
      
  • Status changed to Fixed 9 months ago
  • 🇨🇦Canada mandclu

    I decided to take a simpler approach and only worry about properly handling values from Smart Date fields. The latest commit addresses that, including fields with multiple values, which in turn means that recurring events are properly handled.

    Merged in, and I will open a separate issue about properly handling views without grouped rows.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024