Multiple problems with breadcrumbs on node edit forms (and probably on other entity forms too)

If Gin theme insist to override breadcrumb via a hook_preprocess_breadcrumb i suggest it should add proper cache tags and/or context to the $variables to reduce the chance of display the wrong cached values.

Please do not concatenate strings to display! Use the string translation.

Please feel free to open an MR to address these issues

I've created a merge request with the requested changes.

I could not reproduce the bug you mention. I get Edit Page/ Edit Article correctly.
Editing the Article bundle name to Article2 keeps the breadcrumb as Edit Article (instead of Edit Article2) so the cache tags of the bundle need to be added.

I agree string translation should be used instead of concatenation though.

It looks good.
Thank you

On various cases the original problem still exists.
I try to add more cache tags to built breadcrumb.

The problem is not cache tags, it's cache context.

After one visit to a node edit form, my cache_render table has an entry with this CID:

> entity_view:block:gin_breadcrumbs:[languages:language_content]=en:[languages:language_interface]=en:[route.book_navigation]=book.none:[theme]=gin:[user.permissions]=is-admin

So the next page -- whatever it is -- will get that same cache entry.

Latest version of the MR fixes the problem I've been seeing.

The t() issues seem to be fixed too.

Fixed the tests, it is still RTBC.

Hey @tikaszvince 👋

Thanks for working on this 🙇🙌

I've left some code suggestions otherwise this LGTM.
Moving this back to needs work for now.

Thank you

Hi @saschaeggi,

Updated the MR with the new helper method placed in the same file. If that is not the right place for this function please move it.

Thank you, LGTM, I've fixed one small phpcs issue.

Let's wait for a community review that everything works as expected and afterwards we can move forward with merging this 🤝