- Issue created by @nagy.balint
- Status changed to Needs review
4 months ago 9:18am 31 August 2024
The google_tag_post_update_move_advanced_settings function causes
[warning] Undefined variable $advanced_settings google_tag.post_update.php:19
This is because in the code:
foreach ($google_tags as $tag_container) {
$gtm_tags = $tag_container->getGtmIds();
foreach ($gtm_tags as $tag) {
$advanced_settings['gtm'][$tag] = $tag_container->getGtmSettings();
}
$tag_container->set('advanced_settings', $advanced_settings);
$tag_container->save();
}
If the inner foreach for some reason does not have any iteration, then the $advanced_settings does not exist.
Needs review
2.0
Code