- Issue created by @thejimbirch
- ๐ฎ๐ณIndia gaurav.goyal
gaurav.goyal โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Status changed to Needs review
4 months ago 3:22pm 7 September 2024 - ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
We will have followups, but all threads have been resolved, and this is ready for review.
- Status changed to Needs work
4 months ago 4:05pm 7 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Reviewed - I'm not seeing any major problems, but a few tweaks that need to be made.
One thing that is missing, and blocking commit, is the lack of a
ComponentValidationTest
. There needs to be at least minimal test coverage here, especially since this rips out previous test coverage. You can copy-and-paste a ComponentValidationTest from another component, just be sure to update the@group
and namespace. - Status changed to Needs review
4 months ago 4:22pm 7 September 2024 - ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
- Status changed to RTBC
4 months ago 4:29pm 7 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
No commit blockers left here; merging when it passes tests.
- Status changed to Needs work
4 months ago 4:37pm 7 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Looks like tests are failing. :(
Also, while we're at it, let's take care of it in this issue -- can you add this recipe to the installer? It's quite easy, just modify
drupal_cms_installer/src/Form/RecipesForm.php
. It'll only be one line you need to add; the place is probably fairly obvious. :) - Status changed to Needs review
4 months ago 4:43pm 7 September 2024 - ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
Hope that fixes the failure. I updated the installer for also.
- Status changed to RTBC
4 months ago 4:49pm 7 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
*chef's kiss* If this passes, I'm merging it.
-
phenaproxima โ
committed 54262717 on 0.x authored by
thejimbirch โ
Issue #3470830 by thejimbirch, gaurav.goyal, kerrymick, phenaproxima:...
-
phenaproxima โ
committed 54262717 on 0.x authored by
thejimbirch โ
- Issue was unassigned.
- Status changed to Fixed
4 months ago 6:28pm 7 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
How cool is it to see this finally merged? This really brings some serious SEO-fu to Drupal CMS, and I look forward to helping you iterate and improve it even more in the future.
Automatically closed - issue fixed for 2 weeks with no activity.