Create an advanced SEO Recipe

Created on 28 August 2024, 5 months ago
Updated 7 September 2024, 4 months ago

Problem/Motivation

Let's work on the advanced recipe as we work to get our proposal approved.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Fixed

Component

Track: SEO

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States thejimbirch Cape Cod, Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @thejimbirch
  • Merge request !47Resolve #3470830 "Advanced seo recipe" โ†’ (Merged) created by thejimbirch
  • Pipeline finished with Success
    5 months ago
    Total: 621s
    #267508
  • Pipeline finished with Success
    5 months ago
    Total: 462s
    #267513
  • Pipeline finished with Success
    5 months ago
    #267518
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States thejimbirch Cape Cod, Massachusetts
  • Pipeline finished with Failed
    5 months ago
    Total: 313s
    #269400
  • Pipeline finished with Canceled
    5 months ago
    Total: 284s
    #269463
  • Pipeline finished with Failed
    5 months ago
    Total: 291s
    #269469
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.goyal

    gaurav.goyal โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Canceled
    5 months ago
    Total: 118s
    #269712
  • Pipeline finished with Failed
    5 months ago
    Total: 362s
    #269714
  • First commit to issue fork.
  • Pipeline finished with Failed
    4 months ago
    Total: 661s
    #276107
  • Pipeline finished with Failed
    4 months ago
    Total: 354s
    #276157
  • Pipeline finished with Skipped
    4 months ago
    #276468
  • Pipeline finished with Skipped
    4 months ago
    #276469
  • Status changed to Needs review 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States thejimbirch Cape Cod, Massachusetts

    We will have followups, but all threads have been resolved, and this is ready for review.

  • Pipeline finished with Failed
    4 months ago
    Total: 921s
    #276588
  • Status changed to Needs work 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    Reviewed - I'm not seeing any major problems, but a few tweaks that need to be made.

    One thing that is missing, and blocking commit, is the lack of a ComponentValidationTest. There needs to be at least minimal test coverage here, especially since this rips out previous test coverage. You can copy-and-paste a ComponentValidationTest from another component, just be sure to update the @group and namespace.

  • Pipeline finished with Canceled
    4 months ago
    Total: 230s
    #276610
  • Status changed to Needs review 4 months ago
  • Pipeline finished with Failed
    4 months ago
    Total: 810s
    #276612
  • Status changed to RTBC 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    No commit blockers left here; merging when it passes tests.

  • Status changed to Needs work 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    Looks like tests are failing. :(

    Also, while we're at it, let's take care of it in this issue -- can you add this recipe to the installer? It's quite easy, just modify drupal_cms_installer/src/Form/RecipesForm.php. It'll only be one line you need to add; the place is probably fairly obvious. :)

  • Pipeline finished with Failed
    4 months ago
    Total: 812s
    #276618
  • Status changed to Needs review 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States thejimbirch Cape Cod, Massachusetts

    Hope that fixes the failure. I updated the installer for also.

  • Status changed to RTBC 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    *chef's kiss* If this passes, I'm merging it.

  • Pipeline finished with Failed
    4 months ago
    Total: 855s
    #276622
  • Pipeline finished with Failed
    4 months ago
    Total: 875s
    #276629
  • Pipeline finished with Failed
    4 months ago
    Total: 1510s
    #276648
  • Pipeline finished with Success
    4 months ago
    Total: 892s
    #276670
  • Pipeline finished with Skipped
    4 months ago
    #276679
  • Issue was unassigned.
  • Status changed to Fixed 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    How cool is it to see this finally merged? This really brings some serious SEO-fu to Drupal CMS, and I look forward to helping you iterate and improve it even more in the future.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024