- Issue created by @pdureau
- 🇫🇷France celdia
It always makes writing easier.
I guess
{{ icon("my_pack", "this_icon", {foo: "bar"}) }}
is the icon definition, right ?So wouldn't be better to write
{{ icon(iconDefinition) }}
for example ? - 🇫🇷France mogtofu33
Hi @pdureau, the request is to replace or keep both available?
- 🇫🇷France pdureau Paris
Hi @pdureau, the request is to replace or keep both available?
The existing form (3 parameters) is the expected one. It needs to be kept. The proposal is an alternative form.
Personally, I am not 100% convinced about introducing this new form.
So wouldn't be better to write {{ icon(iconDefinition) }} for example ?
Indeed, but
iconDefinition
must be a Twig mapping, not an executable PHP objetc - 🇫🇷France pdureau Paris
After a few weeks of real life use and feedbacks, we consider the current
icon()
function as OK enough