Change Event Listener from readystatechange to load

Hi @dastan56,

The visitor block was removed, but a new release has yet to be made.

Which version of PHP are you using?

The trailing comma is a change with phpcs. The trailing comma is now encouraged.

📌 Remove the Visitor block Fixed

yes sorry, i did further debugging and found that the tracking script was instead causing the issue so when i checked Disable tracking under advanced settings then the slider loaded in safari, basically the script prevents the $(window).on('load', function(){ from executing in the md_slider init-md-slider.js file and hence the slider is not loaded

these are the versions i use

Drupal Version: 10.3.2
PHP Version 8.2.22

Visitors: 8.x-2.19
md_slider: 1.5.4

i further worked on it, and changed this code in service ScriptService.php on line 433 from this:

    $script .= "
    document.addEventListener('readystatechange', () => {
      // The first readyStateChange will be : interactive
      // The second readyStateChange will be : complete
      if (document.readyState === 'complete') {
        tracker();
      }
    });
    ";

to this:

    $script .= "
        window.addEventListener('load', function() {
        tracker();
    });

seems to fix the issue, now the md_slider loads in the safari, and the visit is also counted, but it causes another, issue the counter is cached for anonymous users, so although the visit is counted but the number is updated only when the cache is cleared, is this ok? should i create a patch for it please let me know

The cache for anonymous users is intentional. I will look into the javascript event issue.

thanks, i have attached the patch

Automatically closed - issue fixed for 2 weeks with no activity.