Sort Get parameters

Created on 23 August 2024, 4 months ago
Updated 15 September 2024, 3 months ago

Problem/Motivation

Sometimes the website can be behind a reverse Proxy. Typically a Varnish server.

And the proxy can be configured to sort GET parameters to avoid duplicated cache entries.

But in this case the hash check is broken and result in access denied.

✨ Feature request
Status

Needs review

Version

2.1

Component

Code

Created by

πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Grimreaper
  • Pipeline finished with Failed
    4 months ago
    Total: 192s
    #262970
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·
  • πŸ‡ΊπŸ‡ΈUnited States luke.leber Pennsylvania

    Retrying the tests against 2.1.x - need to get green before this can land.

  • Status changed to Needs work 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States luke.leber Pennsylvania

    Makes perfect sense to me.

    I think all this needs is an empty post-update hook to ensure caches are flushed, as if any formatter output is held in caches before this change, there will be hash mismatches until it's invalidated.

    This can easily be back ported to 2.0.x, as 2.1.x isn't ready for prime time yet.

  • πŸ‡ΊπŸ‡ΈUnited States luke.leber Pennsylvania

    Err.. actually shouldn't the sorting happen in the ::getHash method?

  • Assigned to Grimreaper
  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·
  • Pipeline finished with Canceled
    3 months ago
    #283552
  • Pipeline finished with Canceled
    3 months ago
    Total: 90s
    #283553
  • Issue was unassigned.
  • Status changed to Needs review 3 months ago
  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Hi,

    Thanks for the review. MR updated.

    Also updating the version in the issue as the MR target branch had been updated.

  • Pipeline finished with Failed
    3 months ago
    Total: 243s
    #283554
Production build 0.71.5 2024