- Issue created by @Grimreaper
- Issue was unassigned.
- Status changed to Needs review
4 months ago 5:38pm 23 August 2024 - πΊπΈUnited States luke.leber Pennsylvania
Retrying the tests against 2.1.x - need to get green before this can land.
- Status changed to Needs work
3 months ago 1:23am 13 September 2024 - πΊπΈUnited States luke.leber Pennsylvania
Makes perfect sense to me.
I think all this needs is an empty post-update hook to ensure caches are flushed, as if any formatter output is held in caches before this change, there will be hash mismatches until it's invalidated.
This can easily be back ported to 2.0.x, as 2.1.x isn't ready for prime time yet.
- πΊπΈUnited States luke.leber Pennsylvania
Err.. actually shouldn't the sorting happen in the ::getHash method?
- Assigned to Grimreaper
- Issue was unassigned.
- Status changed to Needs review
3 months ago 7:21am 15 September 2024 - π«π·France Grimreaper France π«π·
Hi,
Thanks for the review. MR updated.
Also updating the version in the issue as the MR target branch had been updated.