Unbreak CI: #3458422 in Drupal 10.4 changed a method signature XB is overriding

Created on 23 August 2024, 3 months ago

Updated 6 September 2024, 3 months ago

Overview

📌 Add string return typehints to protected test helper methods Needs review landed upstream, and changed the signature of \Drupal\Tests\RandomGeneratorTrait::randomMachineName().

This now causes a fatal PHP error for XB because \Drupal\Tests\experience_builder\Kernel\Entity\ComponentValidationTest::randomMachineName() still matches the old signature.

Proposed resolution

User interface changes

📌 Task

Status

Fixed

Component

Page builder

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

Merge Requests

!201Unbreak CI: #3458422 in Drupal 10.4 changed a method signature XB is overriding
Merged
🇧🇪Belgium wim leers
updated 3 months ago

Comments & Activities

Issue created by @wim leers
Merge request !201#3469865: Unbreak CI: #3458422 in Drupal 10.4 changed a method signature XB is overriding → (Merged) created by wim leers
Pipeline finished with Skipped
3 months ago
#262535

Comment 3 months ago →

System Message

Wim Leers → committed 8b8e0e8b on 0.x

Issue #3469865: Unbreak CI: #3458422 in Drupal 10.4 changed a method...

Issue was unassigned.
Status changed to Fixed 3 months ago9:47am 23 August 2024
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024