[PP-1] Occasional PHP warning when refreshing XB

Warning: Trying to access array offset on null in Drupal\experience_builder\Form\ComponentPropsForm->buildForm() (line 52 of modules/custom/experience_builder/src/Form/ComponentPropsForm.php). Drupal\experience_builder\Form\ComponentPropsForm->buildForm(Array, Object, Object) call_user_func_array(Array, Array) (Line: 528) Drupal\Core\Form\FormBuilder->retrieveForm('component_props_form', Object) (Line: 279) Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73) Drupal\Core\Controller\FormController->getContentResult(Object, Object) call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28) Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32) Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36) Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 709) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments & Activities

Issue created by @lauriii
Status changed to Postponed 4 months ago8:23am 23 August 2024
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
That's for

$component_machine_name = json_decode($this->getRequest()->get('tree'), TRUE)['type'];
… so that'd mean that the client is not sending tree in its request body 😱

👆 This is exactly what 📌 Also validate request bodies against the OpenAPI spec Downport would/should catch.

Rather than determining when exactly this happens, I propose to instead wait for 📌 Also validate request bodies against the OpenAPI spec Downport (which should be ready very soon), which should A) surface this problem, B) will make it easy to write test coverage (i.e. just executing a sequence of steps should result in a 4xx response from the server, which would fail the test).
Status changed to Closed: cannot reproduce 4 months ago2:29pm 4 September 2024
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Also validate request bodies against the OpenAPI spec Downport landed. I don't see how this particular case could occur anymore.

[PP-1] Occasional PHP warning when refreshing XB

Overview

Proposed resolution

User interface changes

Comments & Activities