- Issue created by @wim leers
- Merge request !197#3469686: Changing default theme can break HTML forms generated by XB API routes → (Merged) created by wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Can't get any core theme so far to break it. Perhaps there really was something exceptional about https://www.drupal.org/project/demo_design_system → ? 🤔
We'll have to figure out what.
- 🇫🇮Finland lauriii Finland
I don't think we should spend time figuring out what in that theme is breaking this. Regardless of the reason, we should ensure the forms are rendered with a theme that is known to work. I'm wondering if we should use Stark for this? Or maybe we could use a hidden theme specifically created for this so that it's not visible through the UI.
- 🇫🇮Finland lauriii Finland
do allow the theme to be changed?
Why would we allow that? I don't see why would anyone do this.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- Assigned to utkarsh_33
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This is in the critical path for 🌱 Milestone 0.1.0: Experience Builder Demo Active — see #3454125-53: Implement temporary design system for the DrupalCon Barcelona demo → .1.4.
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
3 months ago 11:39am 26 August 2024 - Assigned to bnjmnm
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@utkarsh_33: there's 2 nits to address, but they aren't commit-blocking.
I did find this doesn't actually quite work yet though, for subtle/tricky reasons, and I'm not quite sure how to proceed. I think @bnjmnm has ideas around this: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- 🇺🇸United States bnjmnm Ann Arbor, MI
Brute force Stark as a dependency is fine.
- Issue was unassigned.
- Status changed to RTBC
3 months ago 4:12pm 29 August 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Great! I wasn't entirely confident that this made sense from a
semi_coupled.engine
POV — so great to have your +1 😊 - Assigned to tedbow
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Needs final sign-off from a BE reviewer. It's late in the European day, so asking @tedbow.
- Issue was unassigned.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Actually … I think @bnjmnm's sign-off alone is more than sufficient. No need to succumb to
CODEOWNERS
as an iron first.This helps accelerate 📌 Implement temporary design system for the DrupalCon Barcelona demo Needs work , so bypassing approval for this MR…
-
Wim Leers →
committed 656f7095 on 0.x
Issue #3469686 by Wim Leers, utkarsh_33, lauriii, bnjmnm: Changing...
-
Wim Leers →
committed 656f7095 on 0.x
- Status changed to Fixed
3 months ago 4:31pm 29 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.