[2.0.0-beta2] Test PropTypeInterface::normalize()

If possible, fix an issue in LinksPropTypeNormalizationTest where 2 tests where disabled (commented) because they need the service container:

If you need the service container then you need a KernelTest instead of a UnitTest.

Should I change the whole test class into a KernelTest or should I split the it into 2 tests (1 unit test and one kernel test) ?

Should I change the whole test class into a KernelTest or should I split the it into 2 tests (1 unit test and one kernel test) ?

Single KernelTest. Maybe all 3 tests can become kernel tests (to keep them in the same folder)

The issue in fact is that the container is called from a static method which is not aware of the container.

What I think we should do :

• move the fixutres data (current static functions) to yaml files
• avoid calling the Url class in the fixtures data (if possible)
• call the Url class dynamically in the test method (if required)
• mock the pathValidator service

Careful, i did some changes in https://git.drupalcode.org/project/ui_patterns/-/blob/a1cba969c36e3891ab...

https://git.drupalcode.org/project/ui_patterns/-/merge_requests/188/diffs

Postponed because I am doing that first 💬 [2.0.0-beta3] InvalidComponentException: [attributes] String value found, but an object is required in ComponentValidator->validateProps() Postponed: needs info and introduce the unit tests for URL, Attributes, and many other prop types.

So, this ticket will keep the following tasks

• Slot tests
• Move stuff to kernel tests and/or mock services

There are 3 unit tests:

• AttributesPropTypeNormalizationTest.php
• LinksPropTypeNormalizationTest.php
• UrlPropTypeNormalizationTest.php

However, they don't cover everything because of limitation of Unit tests. For example:

• AttributesPropTypeNormalizationTest is avoiding testing the render service.
• LinksPropTypeNormalizationTest is avoiding testing TranslatableMarkup & URL

Also, we need tests for SlotPropType::normalize()

Mikael, because you have added tests/src/Kernel/PropTypesNormalizationTest.php in beta6

Do we still need?

• tests/src/Unit/PropTypeNormalization/AttributesPropTypeNormalizationTest.php
• tests/src/Unit/PropTypeNormalization/LinksPropTypeNormalizationTest.php
• tests/src/Unit/PropTypeNormalization/UrlPropTypeNormalizationTest.php

Can we consolidate those in a single collection of kernel tests?

Mikael's answer:

we can consolidate those tests yes and refactor. better to keep as kernel, and continue what i have introduced if possible. the file EnumNormalizationTest has been deleted, or should have been.

Can we have a tests/src/Kernel/PropTypeNormalization/ folder, with one file per prop type? a bit like what I did in tests/src/Unit/PropTypeNormalization ?

just_like_good_vibes → changed the visibility of the branch 3469665-test-proptypeinterfacenormalize to hidden.

did some massive work over there, please review :)

i think we should improve two prop types : ListPropType and NumberPropType.
A the moment, their normalization is not strong enough imho.

let's tackle this in separate tickets.

OK for me to be merged.

However, some tests are still commented:

     // "Standardized structure, flat, with objects" =>
      // self::standardizedFlatObjects(),
     ...
      // "Menu, as generated by the Menu module" => self::menu(),

https://git.drupalcode.org/project/ui_patterns/-/blob/cb853ea951afe89b24...

It would be great to uncomment before merging

ok i added them :)