- Issue created by @agentrickard
- πΊπΈUnited States agentrickard Georgia (US)
If you look at the Jobs list, you can see the variant behavior on D11.
https://git.drupalcode.org/project/domain/-/jobs
Nothing in the code has changed except the test runner. This surfaced in π Mark as Drupal 11 compatible Needs work
- Status changed to Closed: duplicate
7 months ago 6:49pm 21 August 2024 - πΊπΈUnited States agentrickard Georgia (US)
- Status changed to Active
7 months ago 6:59pm 21 August 2024 - πΊπΈUnited States agentrickard Georgia (US)
Not a duplicate. This change breaks my modules.
I have made some changes and this is ready for review. The files to change are detected using INFO_FILES=$(find -L . -name "*.info.yml") within the /modules/custom/$CI_PROJECT_NAME folder, not the top-level directory, to avoid finding every .info.yml. Then xargs sed as suggested.
- πͺπΈSpain fjgarlin
Yeah, not a duplicate, the changes on that issue might have provoked this indeed.
- π¬π§United Kingdom jonathan1055
I commented on the Slack thread but also quickly repeating it here. The work done in #3414505: Allow all sub-modules to be compatible with next_major β should solve your problem of not having a top-level .info.yml file. That has been committed to 'main' branch but not yet tagged as a full
default-ref
release.Can you test using ref
main
and see if this solves the problem? https://project.pages.drupalcode.org/gitlab_templates/info/templates-ver... has instructions for doing this. - Status changed to Closed: duplicate
7 months ago 7:57am 22 August 2024 - πͺπΈSpain fjgarlin
I was about to suggest that. I just realized that this was in main but not in the recommended release yet, so yes, it is a duplicate.
If you test "main" it should work, otherwise just wait as we might do a new release this week or early next week. - π¬π§United Kingdom jonathan1055
When I posted #6 I had not seen your #5, one minute earlier.
In #3414505: Allow all sub-modules to be compatible with next_major β I specifically added
|| true
toINFO_FILES=$(find -L . -name "*.info.yml") || true
as I thought that would be good. But I can't recall if I actually tested it on a project that has no .info.yml at top level. Maybe @agentrickard can do the test with 'main' and post back here to confirm it is all OK.