Contrib.social

Upgrade configuration forms to use ConfigFormBase.

Open on Drupal.org →
Created on 19 August 2024, 9 months ago

Problem/Motivation

The current implementation of the Environment Indicator configuration form extends EntityForm. While this approach works, it does not align with Drupal’s best practices for handling configuration entities. Since the EnvironmentIndicator entities are configuration entities, the form should extend ConfigFormBase to ensure consistency and proper management of configuration data.

Proposed resolution

  • Update the EnvironmentIndicatorForm class to extend ConfigFormBase instead of EntityForm.
  • Refactor the form to ensure it adheres to the patterns and practices associated with ConfigFormBase.

Remaining tasks

  • Refactor EnvironmentIndicatorForm to extend ConfigFormBase.
  • Test the updated form to ensure it works correctly with the EnvironmentIndicator configuration entity.
  • Update any relevant documentation and comments in the code to reflect this change.

User interface changes

No significant UI changes are expected. The form should function the same from the user's perspective.

API changes

The form class will now extend ConfigFormBase instead of EntityForm. This may impact how the form is instantiated or extended in custom implementations.

Data model changes

No data model changes are expected as a result of this change.

📌 Task
Status

Closed: won't fix

Version

4.0

Component

Code

Created by

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @trackleft2
  • Status changed to Closed: won't fix 9 months ago
  • Comment 9 months ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    I was wrong about this, EntityForm is the correct, I was confused.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024