- Issue created by @Anybody
- π©πͺGermany Anybody Porta Westfalica
I think it makes sense to use "commerce" as context for this kind of weight?
commerce_shipping would be too specific I think and "product" also? Any other feedback?
For German this is indeed a major issue. - πΊπΈUnited States TomTech
Seems reasonable!
All languages are complicated. :)
I think using 'physical' as the context might be more appropriate, since that is the module that defines the weight field. (We'd also need to add this same tweak to that module. Using 'physical' would also benefit other projects using the physical module, but not using commerce.)
- Status changed to Needs review
5 months ago 4:19pm 19 August 2024 - π©πͺGermany Anybody Porta Westfalica
Thanks @TomTech! I'm also fine with that. Should we wait for further feedback or change it right now?
- πΊπΈUnited States TomTech
I've created a related issue in the Physical module to sync this up.
- πΊπΈUnited States TomTech
Found one more!
It was easy to overlook, as it was a column in a table builder, which often is used for sorting/tableDrag. In this case, it is the actual Weight/Gewicht. (There is another table builder, that is the other weight.)
-
TomTech β
committed ac4a5500 on 8.x-2.x authored by
anybody β
Issue #3468965 by anybody, TomTech: Add translation context for the "...
-
TomTech β
committed ac4a5500 on 8.x-2.x authored by
anybody β
- Status changed to Fixed
5 months ago 9:15am 26 August 2024 - π©πͺGermany Anybody Porta Westfalica
Thank you @TomTech! Setting this fixed, as it's already merged.
Automatically closed - issue fixed for 2 weeks with no activity.