- Issue created by @andre.bonon
- First commit to issue fork.
- Merge request !102fix: [#3468942] Allow user-set 403/404 pages to override the theme template. β (Merged) created by froboy
-
froboy β
committed dc2da26d on 3.1.x
fix: [#3468942] Allow user-set 403/404 pages to override the theme...
-
froboy β
committed dc2da26d on 3.1.x
- Status changed to Needs review
3 months ago 6:39pm 4 September 2024 - π§π·Brazil andre.bonon
This piece of code is no longer needed (these templates are suggested by default now):
// Adds template suggestions for 40x pages. $http_error_suggestions = [ 'system.403' => 'page__403', 'system.404' => 'page__404', ]; $route_name = \Drupal::routeMatch()->getRouteName(); if (isset($http_error_suggestions[$route_name])) { $suggestions[] = $http_error_suggestions[$route_name]; }
- Status changed to Active
3 months ago 8:41pm 5 September 2024 - πΊπΈUnited States froboy Chicago, IL
@andre.bonon is there a harm in keeping it for now? I think many folks using this may still be using Drupal 10.0.x.
- Merge request !103fix: [#3468942] Validates if the Exception is NotFoundHttpException before... β (Merged) created by andre.bonon
- Status changed to Needs review
3 months ago 8:08pm 9 September 2024 - π§π·Brazil andre.bonon
Is openy_carnation still compatible with 10.0.x?
Regardless of what we decide, I've pushed a fix to ensure the exception is an instance of NotFoundHttpException, because in some cases the Exception might be of another type and the response doesn't have a status code.
- Status changed to RTBC
3 months ago 9:02pm 9 September 2024 - πΊπΈUnited States froboy Chicago, IL
@andre.bonon yes, openy_carnation should stay compatible with 10.0.x.
This change makes sense and I think it helps to make the code more readable as well. Thank you.
-
andre.bonon β
committed ea71869a on 3.1.x
fix: [#3468942] Validates if the exception is a instance of...
-
andre.bonon β
committed ea71869a on 3.1.x
-
andre.bonon β
committed 4348a651 on 3.1.x
fix: [#3468942] Validates if the Exception is NotFoundHttpException...
-
andre.bonon β
committed 4348a651 on 3.1.x