AssetResolverTest should use ::willReturnMap() for mocking

Unsure if this is a bug or a task. Bug because now

AssetResolverTest::testGetJsAssets

is passing without enough return-values in it's Mock, so the test is untrustworthy. Task because that's what we usually do for breaking changes in a dependency update.

Went with task for now.

By the power of , blunt trail-and-error it seems that $this->libraryDiscovery->expects($this->any())->method('getLibraryByName')->willReturnOnConsecutiveCalls() in Drupal\Tests\Core\Asset\AssetResolverTest::testGetJsAssets needs to return twelve instead of the current six values.

I'll leave it to bigger brains what those values should be.

Thanks @catch.

The test-failure I've opened this issue for is now indeed gone, however....
It's replaced with three failures that will be solved when [3468502] lands.

So I think the right thing to do now is postponing this issue on that one.

Can’t the AssetResolverTest fix be done now, independently from the dependency bump? That sounds like a bug that needs fixing anyway

Absolutely, makes sense to me.

However I would like to bump the version later on (not necessarily in this issue), because, at least to me, this issue shows the new version adds test coverage of our tests that is/was at least needed in one case.
I think we want this extra test coverage for our tests, so we need a bump.

Sure. In any case IMHO it’s good practice to keep these tools updated. We will need this for working on PHPUnit bump to 11 anyway.

Thanks @mondrake, per usual we agree :)

Rebased so the MR only includes the fix to the tests and also re-titling for the specific bug fix here.

Thanks @catch, code changes without the version bump, so RTBC.

Tagging for followup about version bumping of PHPUnit.

Committed and pushed 239e6f638d to 11.x and 8d9b67396d to 11.0.x and 2f5393f842 to 10.4.x and fd1c79fa51 to 10.3.x. Thanks!

Looks like PHPUnit will be bumped in 📌 sebastianbergmann/comparator:5.0.2 Introduces (for Drupal) breaking changes Fixed , removing tag.

longwave → closed merge request !9242

Automatically closed - issue fixed for 2 weeks with no activity.