- Issue created by @ksenzee
- First commit to issue fork.
- πΊπΈUnited States joshuami Portland, OR
I started an issue fork with a working version of @ksenzee's code. I had to make a couple of small revisions to get it working on a Drupal 10.4 instance as a custom module.
It still needs some tests, but it got me wondering about architecture. Do you want this as a submodule or integrated directly into Tour. I could make a case for either.
@smustgrave, do you have a preference?
- πΊπΈUnited States smustgrave
I'd want to be configurable either way so it can be turned off or on easily.
- Merge request !105Resolve #3468619 "Add option to open tours automatically" β (Merged) created by joshuami
- πΊπΈUnited States joshuami Portland, OR
After messing with this a bit more, I have the tests for tourauto passing, but there is a failure to the tour tests in 2.0.x.
It seems like a tip that should be created in
tests/src/Functional/TourTest.php
on line 202 is not being created correctly due to a typo. I've updated that test in addition to all the changes for the tourauto functionality. - πΊπΈUnited States joshuami Portland, OR
Ugh. That's what I get for formatting my issue summary in an editor with settings to limit the line length to 80. (Laughs)
- πΊπΈUnited States smustgrave
I have a contrib day coming up Friday Iβll add to my list thanks!
-
smustgrave β
committed c98b8166 on 2.0.x authored by
joshuami β
Resolve #3468619 "Add option to open tours automatically"
-
smustgrave β
committed c98b8166 on 2.0.x authored by
joshuami β
- πΊπΈUnited States smustgrave
Initial testing seems good to me! Since this is a separate module I'm fine adding now and can fine tune later when more people use it.