Test SDC conversion script and guide with demo_design_system/components/02-molecules/map

sea2709 → changed the visibility of the branch 3468125-test-sdc-conversion to hidden.

sea2709 → changed the visibility of the branch 3468125-test-sdc-conversion to active.

Hi @Kristen,

I think we might need to review how we should set up attributes property in SDC components. From my understanding, attributes property should have the type "Drupal\Core\Template\Attribute".

When I checked the component map (02-molecules/map), I noticed that in this component template, we include 2 other twig files for rendering iframe and button. In my opinion, when we convert these components into SDC, we should render components instead off including twig files.

I just want to demonstrate how I think we should use SDC components, when you have a chance, can you take a look at this commit https://git.drupalcode.org/issue/demo_design_system-3468125/-/commit/288... ? Not sure if it's a correct implementation (it breaks the storybook), but I think we might consider about attributes property and how to render components inside components.

Just a heads up, I did some testings to remove attributes property from the YML files, and it's still working, I can pass attributes to components. So I guess, attributes is a built-in property in a component, and we don't need to define it! Please correct me if I'm wrong!

Thanks!

1. This issue is just for map but I noticed some button and iframe files changed here.

2. Interesting about the attributes... I haven't looked into that but would you create a separate issue on that and assign to me that explains the problem and approach to update the files?

3. Also, can you compare your map work against the recent dev changes? There was recently a commit of all baseline yaml and readme files. It would be helpful to compare your results against that to see if they align or the files should be updated.

p.s. Looking at the example components in:

https://git.drupalcode.org/project/experience_builder/-/merge_requests/2...

supports your thoughts on the attributes.

Changing status.

Closing this one in lieu of baseline and attributes work on other issues that were informed by this work.

Note there are follow-up issues to finalize the includes/embeds/etc:

📌 Reconcile components vs SDC namespaces for SDDS includes/embeds Postponed

Automatically closed - issue fixed for 2 weeks with no activity.