Test SDC conversion script and guide with demo_design_system/components/01-atoms/iframe

@Kristen Pol Below are the findings

- Reviewed the SDDS SDC conversion guide
- Used the conversion script to generate the yml file and README.md
- The iframe.component.yml & README.md file were generated inside demo_design_system/components/01-atoms/iframe
- Copied the demo_design_system/components/01-atoms/ideam to demo_design_system/starshot_demo/components/01-atoms/iframe
- Verified the SDC component in the SDC Registry

Thanks!

Note: The iframe component doesn't need to be added to the starshot_demo subtheme.

Also, can you compare your work against the recent dev changes? There was recently a commit of all baseline yaml and readme files. It would be helpful to compare your results against that to see if they align or the files should be updated with some of your suggestions

@kristen pol Removed the component from the starshot_demo subtheme.

The recent dev changes have made the vertical_spacing the required prop in the component.yml for iframe. IMO, it should be the url Updated the MR with the same.

https://git.drupalcode.org/project/demo_design_system/-/blob/1.0.x/components/01-atoms/iframe/iframe.component.yml?ref_type=heads

Agreed! I'll get this merged in, thanks.

Not sure why pipeline is being weird so merged it on the command line. Thanks!

kristen pol → closed merge request !16

Automatically closed - issue fixed for 2 weeks with no activity.