- Issue created by @Kristen Pol
- Assigned to imalabya
- Issue was unassigned.
- Status changed to Needs review
3 months ago 7:27am 15 August 2024 - 🇮🇳India imalabya Bangalore
@Kristen Pol Below are the findings
- Used the conversion script to generate the yml file and README.md
- Thevideo.component.yml
&README.md
file were generated insidedemo_design_system/components/01-atoms/video
- Copied thedemo_design_system/components/01-atoms/video
todemo_design_system/starshot_demo/components/01-atoms/video
- Verified the SDC component in the SDC Registry - Status changed to Needs work
3 months ago 6:08am 20 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks!
Note: The video component doesn't need to be added to the starshot_demo subtheme.
Also, can you compare your work against the recent dev changes? There was recently a commit of all baseline yaml and readme files. It would be helpful to compare your results against that to see if they align or the files should be updated with some of your suggestions
- Status changed to Needs review
3 months ago 11:29am 20 August 2024 - 🇮🇳India imalabya Bangalore
@kristen pol Removed the component from the starshot_demo subtheme.
The recent dev changes have made the
title, sources, poster, width, height & fallback_text
the required prop in the component.yml for iframe. IMO, it should be the sources. Updated the MR with the same. - Status changed to Fixed
3 months ago 6:11am 21 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks. I agree and have updated the required fields.
Automatically closed - issue fixed for 2 weeks with no activity.