Test SDC conversion script and guide with demo_design_system/components/01-atoms/video

Created on 14 August 2024, 4 months ago
Updated 11 September 2024, 3 months ago

Problem/Motivation

This issue is for imalabya to test the SDC conversion script and the guide using:

  • demo_design_system/components/01-atoms/video

Steps to reproduce

Proposed resolution

Go through the conversion guide and try to convert the component using the script and report any feedback.

Remaining tasks

  • Review guide
  • Follow guide to use the script
  • Convert demo_design_system/components/01-atoms/video
  • Report feedback here

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Kristen Pol
  • Assigned to imalabya
  • 🇮🇳India imalabya Bangalore
  • Pipeline finished with Success
    4 months ago
    Total: 296s
    #254654
  • Merge request !17Added SDC component for Video. → (Closed) created by imalabya
  • Pipeline finished with Success
    4 months ago
    Total: 231s
    #254655
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • 🇮🇳India imalabya Bangalore

    @Kristen Pol Below are the findings

    - Used the conversion script to generate the yml file and README.md
    - The video.component.yml & README.md file were generated inside demo_design_system/components/01-atoms/video
    - Copied the demo_design_system/components/01-atoms/video to demo_design_system/starshot_demo/components/01-atoms/video
    - Verified the SDC component in the SDC Registry

  • Status changed to Needs work 4 months ago
  • 🇺🇸United States Kristen Pol Santa Cruz, CA, USA

    Thanks!

    Note: The video component doesn't need to be added to the starshot_demo subtheme.

    Also, can you compare your work against the recent dev changes? There was recently a commit of all baseline yaml and readme files. It would be helpful to compare your results against that to see if they align or the files should be updated with some of your suggestions

  • Status changed to Needs review 4 months ago
  • 🇮🇳India imalabya Bangalore

    @kristen pol Removed the component from the starshot_demo subtheme.

    The recent dev changes have made the title, sources, poster, width, height & fallback_text the required prop in the component.yml for iframe. IMO, it should be the sources. Updated the MR with the same.

  • Pipeline finished with Success
    4 months ago
    Total: 166s
    #259183
  • Pipeline finished with Success
    4 months ago
    Total: 167s
    #259185
  • Status changed to Fixed 4 months ago
  • 🇺🇸United States Kristen Pol Santa Cruz, CA, USA

    Thanks. I agree and have updated the required fields.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024