[10.3] Convert VotingApiWidget plugins and discovery to attributes

Converted the VotingApiWidget annotation to an attribute, Can't find the discovery plugin...

Added attributes to the plugins. The discovery class is the plugin manager. Added properties to the attribute class, added comments. Corrected PHPCS errors.

@TR I think its might be causing this but just trying to get a Drupal 11 env up to do some development for migration. I need the votingapi_widgets module installed and im doing some things focused around that meaning im installing the 2.0.x branch as it has 11 support for now and hitting this error

14:25:39 WATCHDOG: [ERROR] [node] Drupal\Component\Plugin\Exception\PluginNotFoundException: The "fivestar" plugin does not exist. Valid plugin IDs for Drupal\votingapi_widgets\Plugin\VotingApiWidgetManager are:

Its seems like its not able to discover any of the plugins

Yes you are correct, I forgot to move the plugins into the new directory (src/Plugin/VotingApiWidget instead of src/Plugin/votingapi_widgets) and change the corresponding namespace in the plugins.

I will post the changes later today - don't have time now.

This is one example of why this module desperately needs test cases - this should have been caught by even the simplest automated test.

I think MR !18 should fix it for you. If you can download the patch https://git.drupalcode.org/project/votingapi_widgets/-/merge_requests/18... and try it out I would appreciate it.

Thanks, that seems to have done the job I not longer receive the error but the fivestars are no longer appearing might be something I need to change on my end so will look into it.

Just a quick update - Yeah it was something I was doing wrong all is working with the changes thanks for the quick turnaround @TR

Thanks. Committed.

Automatically closed - issue fixed for 2 weeks with no activity.