- Issue created by @pdureau
- Status changed to Postponed
5 months ago 4:11pm 13 August 2024 - 🇫🇷France mogtofu33
I think we already replaced getPath() with getSource() to be more generic.
Still 'content' is part of the renderable, so even if for now only svg extractor use it, the fact that we pass the optional content around make it generic enough I think, to discuss.
- 🇫🇷France pdureau Paris
I think we already replaced getPath() with getSource() to be more generic.
Indeed, getSource() instead of getPath() because sources can be URL.
- Status changed to Active
5 months ago 9:17am 26 August 2024 - 🇫🇷France pdureau Paris
IconDefinition:getRenderable()
must not hardcodecontent
which is a data specific to SvgExtractor:( 'content' => new FormattableMarkup($this->getContent(), []),)
Do we need to add an attribute in IconExtractor where the extractor can tell which specific data it is collecting:
#[IconExtractor( id: 'svg', label: new TranslatableMarkup('SVG'), description: new TranslatableMarkup('All files from one or many paths. Works for any file type.'), collected_data: [ 'content' => "string" ], forms: [ 'settings' => IconPackExtractorForm::class, ] )]
And then use this information in IconDefinition or elsewhere.
- Status changed to Postponed
5 months ago 9:47am 26 August 2024 - Assigned to mogtofu33
- Status changed to Active
4 months ago 10:01am 16 September 2024 - Issue was unassigned.
- Status changed to Closed: duplicate
4 months ago 11:09am 18 September 2024 - 🇫🇷France mogtofu33
Fixed in 📌 [Meta Beta release] Clean code, no default template, better preview Fixed