Contrib.social

[1.0.0-alpha2] Icon sets with 0 icons must be considered as disabled

Open on Drupal.org →
Created on 12 August 2024, 4 months ago
Updated 26 August 2024, 4 months ago

Problem/Motivation

Icon sets with 0 icons must not be visible in widgets and lists.

So, a design system implementator can add all the iconsets he wants, and the theme user can decide which one he use according to the downloaded assets.

For example, UI Suite Bootstrap can define all those iconsets in the YAML:

  • Bootstrap
  • Font Awesome
  • Feather
  • Octicon

But some site owner may decide to only downloads some og them

Proposed resolution

I think it is already the case, but let's check.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @pdureau
  • First commit to issue fork.
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇫🇷France mogtofu33

    A bit harder as it seems as icon pack plugin is not aware of icons, never needed to be. The pack manager is calling extractor getIcons() only the first time there is a call to it, regardless definition loading.
    As well the pack manager code seems to keep assuming there could be multiple extractor by icon pack.
    Need work, moved to alpha3.

  • Issue was unassigned.
  • Status changed to Fixed 4 months ago
  • Comment 4 months ago →
    🇫🇷France mogtofu33

    Finally fixed in dev for alpha2.

  • Status changed to Fixed 4 months ago
  • Comment 4 months ago →
    🇫🇷France pdureau Paris
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024