- Issue created by @chroid
- Status changed to Needs work
about 1 year ago 2:33am 14 August 2024 - πΊπΈUnited States cmlara
I was debating if we should consider deploying CSS themes here, however we are generating a PNG which limits the usefullness of being able to fully theme (no ability to change colors inside a PNG)
Setting the CSS for the field should work, however I wonder if we should be looking at the QRCode library to generate the background color. https://php-qrcode.readthedocs.io/en/main/Usage/Configuration-settings.h...
I'm moving this to 2.x as we would want to fix this in the working branch and than backport to 1.x
As a bit of information, D.O. has also migrated fully away from patch files and now uses only Merge Requests for all issues. More details can be found in https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... β on how to work with MR's on project issues.
- π³πΏNew Zealand chroid
Hey Conrad,
Thanks for the feedback.
Understood on the MR process, I realised after posting and reading a note that MR's were now the preferred methode, but time pressures prevented me from circling back.
I'll let someone a little more knowledgeable handle the config settings suggestion, but will keenly watch for updates/further comments!
- Merge request !132Issue #3467006 by chroid, cmlara: QR code difficult to see on dark mode themes β (Merged) created by cmlara
- Merge request !133Issue #3467006 by chroid, cmlara: QR code difficult to see on dark mode themes β (Merged) created by cmlara
- πΊπΈUnited States cmlara
Opened MR's for 2.x and 8.x-1.x that set the transparency to FALSE allowing the White BG of the default image to render.
The library does allow outputting SVG, we coul consider that in a separate issue if we desire doing so to allow more direct theme control
- π³πΏNew Zealand chroid
Can confirm with a fresh build and the MR branch checked out, we get good contrast on the QR!
- πΊπΈUnited States cmlara
Thank you for the confirmation.
Merging to Dev.
-
cmlara β
committed 743f242a on 2.x
Issue #3467006 by chroid, cmlara: QR code difficult to see on dark mode...
-
cmlara β
committed 743f242a on 2.x
-
cmlara β
committed 848d9fe6 on 8.x-1.x
Issue #3467006 by chroid, cmlara: QR code difficult to see on dark mode...
-
cmlara β
committed 848d9fe6 on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.