Contrib.social

[1.0.0-alpha2] Don't show icon settings where there is no options

Open on Drupal.org →
Created on 8 August 2024, 4 months ago
Updated 26 August 2024, 4 months ago

Problem/Motivation

A empty "Settings" fieldset is shown when there is options.

Steps to reproduce

Create an iconset without any options:

bootstrap_svg:
  label: Bootstrap
  description: Bootstrap icons from SVG files.
  extractor: svg
  config:
    sources:
      - /libraries/bootstrap-icons/{icon_id}.svg
  template: "..."

then:

  1. create a icon field in a content bundle
  2. got to form display, and activate "Show settings" in the field widget
  3. create a content from this bundle
  4. pick an icon from the form element
  5. See the "Settings" fieldset is empty

Proposed resolution

Hide fieldset when no options. We know this fieldset content is dynamic, so it must not be that easy.

Also: "Settings" VS "Options"? Is it alwyas the same thing? Is it relevant to use the same word everywhere?

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024