Toolshed autocomplete might need core/drupal.autocomplete

Created on 7 August 2024, 8 months ago
Updated 29 August 2024, 8 months ago

Hi,

When I upgraded the site from D10.2 to D10.3, I found there was a missing style for a spinning icon at the end of the text field.

I noticed that on Drupal 10.3, the system base library removed some stylings for autocomplete-loading component.
On 10.2, Drupal loads the CSS file css/components/autocomplete-loading.module.css, but this file is removed from loading on 10.3
https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/modules/sys...
https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/modules/sys...

So I think toolshed autocomplete library should add core/drupal.autocomplete as a dependency.

Thanks!

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States sea2709 Texas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sea2709
  • First commit to issue fork.
  • Merge request !10added missing library → (Open) created by Unnamed author
  • Status changed to Needs review 8 months ago
  • 🇮🇳India sarwan_verma

    Hi ,
    I have created MR!10 for the above issue, Please review it once.

    Thanks!.

  • Assigned to lemming
  • Status changed to Fixed 4 months ago
  • 🇺🇸United States lemming

    I've added styles for applying the default autocomplete styling starting with release Beta14

    The update was made to this CSS file and is based on Claro from Drupal 10.3 & Drupal 11.
    Autocomplete.css

    Previously Drupal had this styling for the autocomplete element separate from the autocomplete functionality they provided. The change from Drupal core, moves the styling with the autocomplete library, which include the JQuery UI and all the Javascript files, which make sense for Drupal core, but is applying too many dependencies that the toolshed autocomplete doesn't need.

    The default styling is very simple and provides a default. Themes, like Claro, are able to override the styling. I've also updated the JS to be compatible with Claro styling (this commit).

    Thanks for reporting this issue and helping to find a resolution.

  • 🇺🇸United States lemming
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024