- Issue created by @mably
- @mably opened merge request.
- 🇫🇷France joachim desarmenien Bordeaux
joachim desarmenien → made their first commit to this issue’s fork.
- Status changed to Needs review
2 months ago 2:22pm 5 September 2024 - 🇨🇦Canada mikeohara Moncton, NB
Things to consider for testing:
- Are these buttons enabled by default?
- How do these affect backwards compatibility with existing installs?
I would worry a big change like this might cause issues with existing installations. Could this be an add-on submodule and still achieve the same effect?
Scope issues:
I would consider breaking this up into smaller blocks. The a11y changes especially are important, and would consider them sooner over a new feature add like the added buttons. Or even consider this whole thing as a v2 of the module. (this would also be safe for existing installs) and backporting the a11y stuff, specifically to the 1.x branch.
- 🇫🇷France mably
Hi Mike, thanks for having a look at our issue.
All the buttons are disabled by default and not displayed.
It should not affect existing installations and be backward compatible.
We are ok with merging this in a new 2.0.x branch of the module (this is what we are currently doing with the views_filters_summary → module).