Created on 5 August 2024, about 1 month ago

Address some of the problems identified by eslint

πŸ“Œ Task
Status

Active

Version

4.0

Component

Rules Core

Created by

πŸ‡ΊπŸ‡ΈUnited States TR Cascadia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @TR
  • Merge request !64Issue #3466076 by TR: eslint changes β†’ (Open) created by TR
  • πŸ‡ΊπŸ‡ΈUnited States TR Cascadia

    Only thing left is this:

    /builds/project/rules/web/modules/custom/rules/config/schema/rules.context.schema.yml
      25:3  error  Empty mapping values are forbidden  yml/no-empty-mapping-value

    And the comments in rules.context.schema.yml mention that the mapping value was deliberately left empty, so I don't want to change that.

    However, it would be nice to be able to suppress this one eslint error message in this one location, like we can with cspell:ignore or phpcs:ignore. But I haven't found a way to do that other than turn off eslint (via .eslintignore) for the entire rules.context.schema.yml file, which I don't want to do.

    Perhaps instead there's a better way to write the schema if the mapping needs to be extended.

  • πŸ‡ΊπŸ‡ΈUnited States TR Cascadia

    Also, this issue is not meant to solve the bigger JavaScript issue raised in πŸ“Œ Update Rules autocomplete.js to track core changes Active .

Production build 0.71.5 2024