Contrib.social

Follow-up for #3461499: transform at-rest field storage settings using FieldItemInterface::settingsFromConfigData()

Open on Drupal.org →
Created on 5 August 2024, about 1 month ago
Updated 19 August 2024, 28 days ago

Overview

Follow-up for 📌 Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed , to fix edge cases identified in 📌 Introduce an example set of representative SDC components; transition from "component list" to "component tree" Fixed .

Specifically these edge cases:

  1. … but that revealed a limitation of the JSON encoding (which is also true of the YAML encoding): all keys are strings. But the keys were meant to be the values. Result: 50 as a choice would always be represented by '50': a string, not an integer!
  2. In debugging that, I discovered ::storageSettingsFromConfigData(), which was added ~10 years ago for addressing precisely this problem. Whew! 😅 Fix: https://git.drupalcode.org/project/experience_builder/-/merge_requests/2...

— #3446722-42: Introduce an example set of representative SDC components; transition from "component list" to "component tree" →

Proposed resolution

Fix1
Fix2

User interface changes

User interface changes

🐛 Bug report
Status

Fixed

Component

Page builder

Created by

Utkarsh_33

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024