- Issue created by @zaporylie
- 🇳🇴Norway zaporylie
Proposed solution:
- Add libraries key to plugin definition.
- Mark js_library as deprecated.
- Append library defined in js_library to the array of libraries for backward compatibility
- Adjust code attaching libraries to follow the new format (libraries are arrays of strings, not strings).
- 🇮🇱Israel jsacksick
Sounds like a good improvement to me, would you like to work on this?
- Merge request !295Issue #3465875 by zaporylie: Rename js_library CommercePaymentGateway plugin key to libraries → (Merged) created by Unnamed author
- Status changed to Needs review
about 1 month ago 12:29pm 5 August 2024 - 🇮🇱Israel jsacksick
I'm thinking that we should deprecate the $js_library property as well (both in the annotation and the attribute, and as discussed in Slack, wondering if we should adopt the deprecated format that includes the version number.
Basically, deprecated in Commerce 3.0.x and removed from Commerce 4.0.x perhaps? Or Commerce 3.1.x? Not sure. -
jsacksick →
committed 0d6da5e7 on 3.0.x authored by
zaporylie →
Issue #3465875 by zaporylie, jsacksick: Rename js_library...
-
jsacksick →
committed 0d6da5e7 on 3.0.x authored by
zaporylie →
- Status changed to Fixed
about 1 month ago 3:06pm 5 August 2024 - 🇮🇱Israel jsacksick
I was writing a change record for this change, but noticed the actual core issue referenced has been fixed since D9.4.5... Do we still need the workaround/fix, or perhaps we still need this mechanism in place so there is no need to add the library as part of the render array?
Automatically closed - issue fixed for 2 weeks with no activity.