Add 'array' return type in Drupal\rules\EventSubscriber\GenericEventSubscriber

/builds/project/scheduler/vendor/symfony/error-handler/DebugClassLoader.php:341 Method "Symfony\Component\EventDispatcher\EventSubscriberInterface::getSubscribedEvents()" might add "array" as a native return type declaration in the future. Do the same in implementation "Drupal\rules\EventSubscriber\GenericEventSubscriber" now to avoid errors or add an explicit @return annotation to suppress this message.

Comments & Activities

Issue created by @jonathan1055
Merge request !63#3465805 Add array type hint in GenericEventSubscriber getSubscribedEvents() → (Merged) created by jonathan1055
Pipeline finished with Success
4 months ago
Total: 284s
#243594
Status changed to Needs review 4 months ago4:01pm 4 August 2024
Comment 4 months ago →
🇬🇧United Kingdom jonathan1055
This MR can be seen in action in the test below, which no longer has the getSubscribedEvents() error. The 'Composer Next Major' job uses the repro from this rules MR
https://git.drupalcode.org/project/scheduler/-/jobs/2334324

Previously the job showed the problem
https://git.drupalcode.org/project/scheduler/-/jobs/2334054#L1000
First commit to issue fork.
Pipeline finished with Skipped
4 months ago
#244824
Comment 4 months ago →
System Message

TR → committed 35ff0a4f on 4.0.x authored by jonathan1055 →
Issue #3465805 by jonathan1055, TR: Add 'array' return type in Drupal\...
Status changed to Fixed 4 months ago6:51pm 5 August 2024
Comment 4 months ago →
🇺🇸United States tr Cascadia

Comment 4 months ago →

🇬🇧United Kingdom jonathan1055

Thanks for the commit. I can now change Schedulers 'next major' testing dependency from

    "require-dev": {
        "drupal/rules": "dev-3465805-add-array-return",
...
    "repositories": {
        "rules": {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/rules-3465805.git"
        },

back to just

 "require-dev": {
        "drupal/rules": "^4@dev",

Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Add 'array' return type in Drupal\rules\EventSubscriber\GenericEventSubscriber

Problem/Motivation

Proposed resolution

Merge Requests

!63Add 'array' return type in Drupal\rules\EventSubscriber\GenericEventSubscriber
Merged

Comments & Activities

Add 'array' return type in Drupal\rules\EventSubscriber\GenericEventSubscriber

Problem/Motivation

Proposed resolution

Merge Requests

!63Add 'array' return type in Drupal\rules\EventSubscriber\GenericEventSubscriberMerged

Comments & Activities

!63Add 'array' return type in Drupal\rules\EventSubscriber\GenericEventSubscriber
Merged