- Issue created by @jonathan1055
- Merge request !161#3465213 array return type for getSubscribedEvents() → (Merged) created by jonathan1055
- Status changed to Needs review
4 months ago 12:06pm 1 August 2024 - 🇬🇧United Kingdom jonathan1055
Why is the Tugboat preview not being generated?
- 🇬🇧United Kingdom jonathan1055
The "entity" module is contrib not core - known as Entity API →
This is the line which is causing the deprecation warnings in the tests
https://git.drupalcode.org/project/entity/-/blob/8.x-1.x/src/EventSubscr...I have raised 📌 Add 'array' return type in Drupal\entity\EventSubscriber\EntityDuplicateSubscriber Active
- 🇬🇧United Kingdom jonathan1055
In the last commit, using the repo from Entity API mr35, the deprecation errors have all been removed. Composer Next Major has
drupal/entity (dev-3465393-EntityDuplicateSubscriber-array-return 4aef0ed)
which shows that the MR repo is being used. -
jonathan1055 →
committed 6d46db4f on 2.x
Issue #3465213 by jonathan1055: Add 'array' return type in...
-
jonathan1055 →
committed 6d46db4f on 2.x
- Status changed to Fixed
4 months ago 1:19pm 2 August 2024 - 🇬🇧United Kingdom jonathan1055
I decided to commit this as-is. There is no need to wait until 📌 Add 'array' return type in Drupal\entity\EventSubscriber\EntityDuplicateSubscriber Active is committed. When that does happen, the composer_next_major.json may cause a problem, in which case it can be modified to use the dev branch of Entity instead of the MR.
But for now, this fixes lots of errors in the Next Major test, and is a big step forward in getting clean PHPUnit tests, and hence readable and usable logs (not filled with error messages)
- Merge request !163#3465213 Event subscriber return type [8.x-1.x] → (Merged) created by jonathan1055
-
jonathan1055 →
committed 72fe92cf on 8.x-1.x
Issue #3465213 by jonathan1055: Add 'array' return type in...
-
jonathan1055 →
committed 72fe92cf on 8.x-1.x
- 🇬🇧United Kingdom jonathan1055
Backported to 8.x-1.x
Drupal 11 PHPUnit and PHPstan jobs are now all green for 8.x-1.x Automatically closed - issue fixed for 2 weeks with no activity.