In
#2207897: Environment indicator cache is written on every request and uses altered version →
it was determined that caching the output of hook_environment_indicator_matched_indicator_alter() is undesirable. However, in environment_indicator_get_active(), condition #3 checks for a cached environment indicator and returns that without running the alter hook. Thus, any alters such as adding the git release are never added beyond the first uncached run (unless overwritten in settings.php via condition #2).
Possible resolutions:
environment_indicator_alter_and_cache() in condition #3 (is consistent with other parts of the function that use the alter_and_cache call, at the expense of a frivolous cache_get)drupal_alter directly in condition #3drupal_alter before cache_set in environment_indicator_alter_and_cache(), partially undoing #2207897. You would then have to do a cache clear on each code deploy, which may or may not be standard for a given site's deployment process.A related concern with options 1 and 2 is for sites that fall back to the git command instead of the remote_release variable, there would be performance hit of a proc call on every request. Perhaps that call should be cached for a limited period of time.
Needs review
2.0
Code
See MR. It is debatable what the "right" expiration time is for the cached git call, or should it be configurable?