- Issue created by @just_like_good_vibes
- Merge request !163fix field formatters and removed the usage of settings extra → (Merged) created by just_like_good_vibes
- Status changed to Needs review
3 months ago 8:37am 3 August 2024 - 🇫🇷France just_like_good_vibes PARIS
Ok, done.
I have added also some bonus :
- i fixed a bug in the context injected by field formatter, especially when used in views, where the bundle is unknown and set to empty string in our case.
- i refactored UI patterns views, to remove the existing service and use a trait for both row and style plugins. i fixed a few existing bugs in the codebase, especially related to view displays and default/overridden options.
- i added a new option to ViewRows source, that allows to use view rows as source, with a specific field only. - Assigned to pdureau
- Assigned to just_like_good_vibes
- Status changed to Needs work
3 months ago 9:41am 4 August 2024 - 🇫🇷France pdureau Paris
Demo with DSFR's tabs:
- The field formatter source doesn't show plugin form
- Duplicated & nested display
- Problem with context
Demo with Bootstrap's table:
Undefined array key "#ajax_url" in Drupal\ui_patterns\Element\ComponentForm::buildPropsForm()
- Maybe this use case is not doable anyway because nested components in a single slot instead of single level component in 2 different slots
- Status changed to Needs review
3 months ago 3:29pm 4 August 2024 - Assigned to pdureau
- Assigned to just_like_good_vibes
- Status changed to Needs work
3 months ago 8:00pm 4 August 2024 - 🇫🇷France pdureau Paris
pulled. And rebased from 2.0.x
During configuration
Seems OK but ComponentFormatter is available in the sources selector also for single value fields (like "title"). If selected, nothing happens. The plgin from is not displayed
After configuration, looking at the result
White screen of death:
TypeError: Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase::checkContextSanity(): Argument #3 ($bundle) must be of type string, null given, called in modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php on line 244 in Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase->checkContextSanity() (line 282 of modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php).
- Status changed to Needs review
3 months ago 6:25am 5 August 2024 - 🇫🇷France just_like_good_vibes PARIS
after testing more, adding a few new tests,
i did some improvements on other edge cases.
it is supposed to be fine now :)
please review Pierre.adding tests is really cool, i think we need really a lot of them.
- Assigned to pdureau
- 🇫🇷France just_like_good_vibes PARIS
Hello,
i have updated a little bit the title and description of the issue, which is now solving more problems than initially expected...
MR is rebased and fully green now :) - Assigned to just_like_good_vibes
- 🇫🇷France pdureau Paris
Unfortunately, I will not be able to review today. you can merge yourself.
-
just_like_good_vibes →
committed b89d730b on 2.0.x
Issue #3465264: Remove usage of setComponentSettingsExtra in field...
-
just_like_good_vibes →
committed b89d730b on 2.0.x
- Issue was unassigned.
- Status changed to Fixed
3 months ago 8:21am 8 August 2024 - Status changed to Fixed
3 months ago 2:47pm 12 August 2024