- Issue created by @ressa
- π¬π§United Kingdom catch
automatic_updates_modules_installed() should at least check the $is_syncing parameter and not show when that's TRUE, although I can't remember off the top of my head whether that gets set during site install.
It's not clear to me exactly why these need to be run immediately and can't just be shown on the status report though, or whether they couldn't be moved to a submit handler on the module install form (or even whatever page that redirects to) rather than also being done during site install, drush etc.
- πΊπΈUnited States phenaproxima Massachusetts
@tedbow and I discussed it and although we're open to other options, the thing we should do in the short term to stop the bleeding in the Starshot prototype is not run the status checks if Drupal is in the middle of being installed.
- Status changed to Needs work
8 months ago 10:44pm 2 August 2024 - π¬π§United Kingdom catch
Double checked the installer and $is_syncing is explicitly set to false there, so wouldn't help by itself and we'd need the separate installer check anyway.
I think this should check both tbh - i.e. it shouldn't be doing this during a config import either, the admin has already seen the message when the module was installed on local, or at the very least won't see it during a site deployment.
- πΊπΈUnited States phenaproxima Massachusetts
I concur. I added a check for config sync, and test coverage for both scenarios.
Also tagging this as critical since it is a serious performance problem.
- Status changed to Needs review
8 months ago 2:21am 3 August 2024 - Status changed to RTBC
8 months ago 4:17pm 7 August 2024 - Assigned to phenaproxima
- Status changed to Needs work
8 months ago 4:39pm 7 August 2024 - Issue was unassigned.
- Status changed to RTBC
8 months ago 4:57pm 7 August 2024 - πΊπΈUnited States phenaproxima Massachusetts
Nice idea; done. I'm restoring RTBC here on the assumption that tests will pass.
-
phenaproxima β
committed 9e199a7e on 3.1.x
Issue #3465155 by phenaproxima, ressa, catch, tedbow:...
-
phenaproxima β
committed 9e199a7e on 3.1.x
- Status changed to Fixed
8 months ago 5:49pm 7 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.