- Issue created by @alok_singh
- Merge request !7Issue #3465127 by jwilson3, alok_singh, bhaveshdas: Rivet Card (Horizontal) - fix image layout for post teasers → (Merged) created by alok_singh
- Status changed to Needs review
6 months ago 6:11am 1 August 2024 - Status changed to RTBC
6 months ago 10:09am 1 August 2024 - 🇮🇳India bhaveshdas
Hi, I have tested MR !7 in Drupal 10
Mobile view Blog post its proper aligned when image is there in blog.
I moved it to RTBC.Thankyou !!
- First commit to issue fork.
- Status changed to Needs work
5 months ago 11:34pm 6 August 2024 - 🇪🇨Ecuador jwilson3
Needs work.
Needs a rebase on latest 1.0.x
The gitlab integration needs to be split out, it is unrelated to the scope of this issue. This is in progress here 📌 Add support for Gitlab CI Active .
It's obvious you didn't runnpm install; npm run build
to build the CSS because the source map file wasn't regenerated. - 🇪🇨Ecuador jwilson3
After reviewing the code change more closely this needs an alternate approach because the upstream Rivet library suffers from the same problem at small screen sizes:
https://rivet.iu.edu/components/card/?example=horizontal-card
I don't see this getting "fixed" in the upstream, therefore, there are a few approaches we can take:
- Use a square image style, to match the intended use of Rivet Horizontal Card.
- Use a utility class in the template to fix the card layout on mobile. For example,
rvt-card rvt-card--horizontal [ rvt-flex-column rvt-flex-row-sm-up ]
(codepen). - Build a custom
rvt-c-card
implementation to properly scope the change, following best practices for extending Rivet.
- Assigned to jwilson3
- Status changed to Fixed
5 months ago 11:47am 7 August 2024 -
jwilson3 →
committed bc6d7486 on 1.0.x authored by
alok_singh →
Issue #3465127 by jwilson3, alok_singh, bhaveshdas: Rivet Card (...
-
jwilson3 →
committed bc6d7486 on 1.0.x authored by
alok_singh →
Automatically closed - issue fixed for 2 weeks with no activity.