- Issue created by @smustgrave
- Status changed to Closed: outdated
16 days ago 3:32pm 19 March 2025 - 🇺🇸United States smustgrave
No one has comeback looking for it, so will assume it was not needed.
Part of the code cleanup have removed
// @todo below logic in D8, maybe we get rid of "remove questions"
//
// Load the quiz node.
$quiz = $form_state['build_info']['args'][0];
// Update the refresh latest quizzes table so that we know what the users
// latest quizzes are.
if ($this->configFactory->get('quiz.settings')->get('auto_revisioning', 1)) {
$is_new_revision = $quiz->hasAttempts();
}
else {
$is_new_revision = !empty($form_state['values']['new_revision']);
}
$num_random = $form_state['values']['num_random_questions'] ?? 0;
$quiz->max_score_for_random = $form_state['values']['max_score_for_random'] ?? 1;
// Store what questions belong to the quiz.
$questions = _quiz_update_items($quiz, $weight_map, $max_scores, $auto_update_max_scores, $is_new_revision, $refreshes, $stayers, $qnr_ids_map, $qqr_pids_map, $compulsories);
// If using random questions and no term ID is specified, make sure we have
// enough.
$assigned_random = 0;
foreach ($questions as $question) {
if ($question->question_status == QuizQuestion::QUESTION_RANDOM) {
++$assigned_random;
}
}
// Adjust number of random questions downward to match number of selected
// questions.
if ($num_random > $assigned_random) {
$num_random = $assigned_random;
$this->messenger()
->addWarning($this->t('The number of random questions for this @quiz have been lowered to %anum to match the number of questions you assigned.', [
'@quiz' => QuizUtil::getQuizName(),
'%anum' => $assigned_random,
]));
}
if ($quiz->type == 'quiz') {
// Update the quiz node properties.
// @todo Drupal Rector Notice: Please delete the following comment after you've made any necessary changes.
// You will need to use `\Drupal\core\Database\Database::getConnection()` if you do not yet have access to the container here.
$this->connection->update('quiz_node_properties')
->fields([
'number_of_random_questions' => $num_random ? $num_random : 0,
'max_score_for_random' => $quiz->max_score_for_random,
])
->condition('vid', $quiz->vid)
->condition('nid', $quiz->nid)
->execute();
// Get sum of max_score.
// @todo Drupal Rector Notice: Please delete the following comment after you've made any necessary changes.
// You will need to use `\Drupal\core\Database\Database::getConnection()` if you do not yet have access to the container here.
$query = $this->connection->select('quiz_node_relationship', 'qnr');
$query->addExpression('SUM(max_score)', 'sum');
$query->condition('parent_vid', $quiz->vid);
$query->condition('question_status', QuizQuestion::QUESTION_ALWAYS);
$score = $query->execute()->fetchAssoc();
// @todo Drupal Rector Notice: Please delete the following comment after you've made any necessary changes.
// You will need to use `\Drupal\core\Database\Database::getConnection()` if you do not yet have access to the container here.
$this->connection->update('quiz_node_properties')
->expression('max_score', 'max_score_for_random * number_of_random_questions + :sum', [':sum' => (int) $score['sum']])
->condition('vid', $quiz->vid)
->execute();
}
As it was unreachable. Opening this to determine if we need it.
Active
7.0
Code - Quiz core
No one has comeback looking for it, so will assume it was not needed.