- Issue created by @pdureau
- 🇫🇷France pdureau Paris
Are we sure this wrapper is added only in Layout Builder preview and not elsewhere?
- 🇫🇷France Grimreaper France 🇫🇷
I will try with UI Styles Layout Builder, but I think this wrapper is needed everywhere as soon as the component is used as a layout.
- Status changed to Postponed
3 months ago 8:55am 5 August 2024 - 🇫🇷France Grimreaper France 🇫🇷
I can't test with UI Styles until 🐛 Type error with callback Active is fixed.
- 🇫🇷France pdureau Paris
Proposal:
--- a/modules/ui_patterns_layouts/src/Element/ComponentAlterer.php +++ b/modules/ui_patterns_layouts/src/Element/ComponentAlterer.php @@ -39,8 +39,14 @@ class ComponentAlterer implements TrustedCallbackInterface { foreach (Element::children($element[$region_id]) as $block_id) { $element["#slots"][$region_id][$block_id] = $element[$region_id][$block_id]; } - if (isset($element[$region_id]['#attributes'])) { + if (isset($element[$region_id]['#attributes']) && isset($element["#slots"][$region_id])) { $element['#region_attributes'][$region_id] = new Attribute($element[$region_id]['#attributes']); + $element["#slots"][$region_id] = [ + "#type" => "html_tag", + "#tag" => "div", + "#attributes" => $element[$region_id]['#attributes'], + "content" => $element["#slots"][$region_id], + ]; } unset($element[$region_id]); }
- Status changed to Active
2 months ago 10:56am 13 September 2024 - Merge request !210Issue #3464894 by grimreaper, pdureau: [2.0.0-beta2] Drag & drop and UI Styles... → (Merged) created by Grimreaper
- Assigned to pdureau
- Status changed to Needs review
2 months ago 11:59am 13 September 2024 -
pdureau →
committed c4f9072c on 2.0.x authored by
grimreaper →
Issue #3464894 by grimreaper, pdureau: Drag...
-
pdureau →
committed c4f9072c on 2.0.x authored by
grimreaper →
- Issue was unassigned.
- Status changed to Fixed
2 months ago 12:47pm 13 September 2024 - Status changed to Fixed
2 months ago 7:23pm 15 September 2024