- Issue created by @Kristen Pol
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Work is happening here:
https://www.drupal.org/community-initiatives/starshot-demo-design-system... β
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Note that I have started work in Google docs but was derailed by the webinar stuff so need to get back to it.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Continuing to tweak this based on feedback.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 4:42am 10 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Okay! After much work, testing, and back-and-forth, this is good enough for more eyes :)
- πΊπΈUnited States sea2709 Texas
I followed the guide and ran the conversion script on my local. It worked :-) Will dig in deeper the testing tomorrow!
- πΊπΈUnited States sea2709 Texas
I went through all the generated YML files in starshot_demo subtheme. The conversion script works well.
One thing came up in my mind, I think it's more about component architecture than the conversion script, I notice that most components have the prop "attributes", which is a string. From the SDC FAQ https://www.drupal.org/docs/develop/theming-drupal/using-single-director... β , attributes prop type is "Drupal\Core\Template\Attribute" . I looked into some component set up examples from https://git.drupalcode.org/project/sdc_examples https://git.drupalcode.org/project/ui_suite_daisyui , I don't see attributes prop is declared in YML file, and attributes can be used in twig files. And I think modifier_class prop can be combined to attributes prop. It's just my thought, but I think it also depends on how XB set up to pass attributes to components.
- Status changed to Fixed
6 months ago 12:29pm 14 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Fantastic π would you make a follow up issue with your findings? We can have one of the frontend devs look at this more carefully over the next couple weeks. And we can discuss with the XB team
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Updated summary with sections.
Automatically closed - issue fixed for 2 weeks with no activity.