[2.0.0-beta1] Code quality: Consumer plugins

------ --------------------------------------------------------------------------------------------------------------------- Line modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php ------ --------------------------------------------------------------------------------------------------------------------- 197 Parameter #2 $bundle of method Drupal\Core\Entity\EntityFieldManagerInterface::getFieldDefinitions() expects string, int|string|null given. 205 Method Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase::findEntityBundleWithField() should return string but returns int|string|null. ------ --------------------------------------------------------------------------------------------------------------------- ------ -------------------------------------------------------------------------------------------------------------- Line modules/ui_patterns_field_formatters/src/Plugin/UiPatterns/Source/FieldFormatterSource.php ------ -------------------------------------------------------------------------------------------------------------- 256 Method Drupal\ui_patterns_field_formatters\Plugin\UiPatterns\Source\FieldFormatterSource::createInstanceFormatter() should return Drupal\Core\Field\FormatterBase but returns object. 282 Cannot access offset 'label' on array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface. 384 Negated boolean expression is always false. 💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon. ------ -------------------------------------------------------------- Line modules/ui_patterns_layouts/ui_patterns_layouts.module ------ -------------------------------------------------------------- 21 Cannot access offset 'annotated_name' on Drupal\Core\Theme\Component\ComponentMetadata. 21 Cannot access offset 'id' on Drupal\Core\Theme\Component\ComponentMetadata. 21 Cannot access offset 'name' on Drupal\Core\Theme\Component\ComponentMetadata. 22 Cannot access offset 'group' on Drupal\Core\Theme\Component\ComponentMetadata. 23 Cannot access offset 'provider' on Drupal\Core\Theme\Component\ComponentMetadata. 25 Cannot access offset 'id' on Drupal\Core\Theme\Component\ComponentMetadata. 27 Cannot access offset 'slots' on Drupal\Core\Theme\Component\ComponentMetadata. 33 Cannot access offset 'icon_map' on Drupal\Core\Theme\Component\ComponentMetadata. 36 Cannot access offset 'icon_path' on Drupal\Core\Theme\Component\ComponentMetadata. 39 Cannot access offset 'id' on Drupal\Core\Theme\Component\ComponentMetadata. 39 Possibly invalid array key type (array<int, string>|string). ------ -------------------------------------------------------------- ------ ---------------------------------------------------------------------------- Line modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewFieldSource.php ------ ---------------------------------------------------------------------------- 71 Negated boolean expression is always false. 💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon. ------ ---------------------------------------------------------------------------- ------ ---------------------------------------------------------------------------- Line modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewsSourceBase.php ------ ---------------------------------------------------------------------------- 83 Left side of && is always true. 💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon. 83 Parameter #1 $key of method Drupal\Core\TempStore\SharedTempStore::get() expects string, int|string|null given. ------ ---------------------------------------------------------------------------- ------ ----------------------------------------------------------------------------- Line modules/ui_patterns_views/src/Plugin/views/row/ComponentRow.php ------ ----------------------------------------------------------------------------- 83 Method Drupal\ui_patterns_views\Plugin\views\row\ComponentRow::buildOptionsForm() has parameter $form with no type specified. 101 Method Drupal\ui_patterns_views\Plugin\views\row\ComponentRow::submitOptionsForm() has parameter $form with no type specified. 109 Property Drupal\views\Plugin\views\PluginBase::$options (array) on left side of ?? is not nullable. ------ ----------------------------------------------------------------------------- ------ -------------------------------------------------------------------------------- Line modules/ui_patterns_views/src/Plugin/views/style/ComponentStyle.php ------ -------------------------------------------------------------------------------- 87 Method Drupal\ui_patterns_views\Plugin\views\style\ComponentStyle::buildOptionsForm() has parameter $form with no type specified. ------ -------------------------------------------------------------------------------- ------ --------------------------------------------------------------------- Line modules/ui_patterns_views/src/UiPatternsViewsManager.php ------ --------------------------------------------------------------------- 45 Cannot access offset 'plugin_type' on array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface. ------ ---------------------------------------------------------------------

Issue created by @pdureau
Comment 4 months ago →
🇫🇷France pdureau Paris
Assigned to just_like_good_vibes
Comment 4 months ago →
🇫🇷France pdureau Paris
Comment 4 months ago →
🇫🇷France pdureau Paris
First commit to issue fork.
Merge request !157Issue #3464291 by just_like_good_vibes: [2.0.0-beta1] Code quality: Consumer plugins → (Merged) created by just_like_good_vibes
Status changed to Needs review 4 months ago7:13pm 29 July 2024
Comment 4 months ago →
🇫🇷France just_like_good_vibes PARIS
let's review :)
Comment 4 months ago →
System Message

just_like_good_vibes → committed 546810ad on 2.0.x
Issue #3464291 by just_like_good_vibes: [2.0.0-beta1] Code quality:...
Status changed to Fixed 4 months ago7:52pm 29 July 2024
Comment 4 months ago →
🇫🇷France just_like_good_vibes PARIS
Comment 4 months ago →
🇫🇷France just_like_good_vibes PARIS
Issue was unassigned.
Comment 4 months ago →
🇫🇷France just_like_good_vibes PARIS
Status changed to Fixed 3 months ago2:47pm 12 August 2024
Comment 3 months ago →
🇫🇷France pdureau Paris

[2.0.0-beta1] Code quality: Consumer plugins

Merge Requests

!157[2.0.0-beta1] Code quality: Consumer plugins
Merged

Comments & Activities

[2.0.0-beta1] Code quality: Consumer plugins

Merge Requests

!157[2.0.0-beta1] Code quality: Consumer pluginsMerged

Comments & Activities

!157[2.0.0-beta1] Code quality: Consumer plugins
Merged