[2.0.0-beta1] Code quality: Plugin management

Created on 28 July 2024, 4 months ago
Updated 12 August 2024, 3 months ago
 ------ --------------------------------------------------------------------- 
  Line   src/Attribute/DerivableContext.php                                   
 ------ --------------------------------------------------------------------- 
  39     PHPDoc type string|null of property                                  
         Drupal\ui_patterns\Attribute\DerivableContext::$deriver is not       
         covariant with PHPDoc type class-string|null of overridden property  
         Drupal\Component\Plugin\Attribute\Plugin::$deriver.                  
         πŸ’‘ You can fix 3rd party PHPDoc types with stub files:               
         πŸ’‘ https://phpstan.org/user-guide/stub-files                         
                                                                              
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Attribute/PropType.php                                             
 ------ ----------------------------------------------------------------------- 
  51     PHPDoc type string|null of property                                    
         Drupal\ui_patterns\Attribute\PropType::$deriver is not covariant with  
         PHPDoc type class-string|null of overridden property                   
         Drupal\Component\Plugin\Attribute\Plugin::$deriver.                    
         πŸ’‘ You can fix 3rd party PHPDoc types with stub files:                 
         πŸ’‘ https://phpstan.org/user-guide/stub-files                           
                                                                                
 ------ ----------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Attribute/PropTypeAdapter.php                                    
 ------ --------------------------------------------------------------------- 
  42     PHPDoc type string|null of property                                  
         Drupal\ui_patterns\Attribute\PropTypeAdapter::$deriver is not        
         covariant with PHPDoc type class-string|null of overridden property  
         Drupal\Component\Plugin\Attribute\Plugin::$deriver.                  
         πŸ’‘ You can fix 3rd party PHPDoc types with stub files:               
         πŸ’‘ https://phpstan.org/user-guide/stub-files                         
                                                                              
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Attribute/Source.php                                             
 ------ --------------------------------------------------------------------- 
  48     PHPDoc type string|null of property                                  
         Drupal\ui_patterns\Attribute\Source::$deriver is not covariant with  
         PHPDoc type class-string|null of overridden property                 
         Drupal\Component\Plugin\Attribute\Plugin::$deriver.                  
         πŸ’‘ You can fix 3rd party PHPDoc types with stub files:               
         πŸ’‘ https://phpstan.org/user-guide/stub-files                         
                                                                              
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------- 
  Line   src/ComponentPluginManager.php                     
 ------ --------------------------------------------------- 
  150    Call to an undefined method object::getSummary().  
 ------ --------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/DerivableContextPluginBase.php                                   
 ------ --------------------------------------------------------------------- 
  89     Cannot access offset 'label' on                                      
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
  164    Cannot access offset 'config_dependencies' on                        
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------- 
  Line   src/DerivableContextPluginManager.php  
 ------ --------------------------------------- 
  18     Plugin definitions cannot be altered.  
 ------ --------------------------------------- 

------ ---------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Derivative/EntityFieldSourceDeriverBase.php                                        
 ------ ---------------------------------------------------------------------------------------------- 
  93     Expression on left side of ?? is not nullable.                                                
  96     Expression on left side of ?? is not nullable.                                                
  98     Parameter #1 $object_or_class of function is_subclass_of expects                              
         object|string, class-string|false given.                                                      
  99     Expression on left side of ?? is not nullable.                                                
  334    Method                                                                                        
         Drupal\ui_patterns\Plugin\Derivative\EntityFieldSourceDeriverBase::getEntityFieldsMetadata()  
         should return array<string, array<string, array|string>> but returns                          
         array<array<string,                                                                           
         array|bool|Drupal\Core\StringTranslation\TranslatableMarkup|string>>.                         
  350    Parameter #1 $label of method                                                                 
         Drupal\Core\Plugin\Context\ContextDefinition::setLabel() expects                              
         string, array|string given.                                                                   
  352    Argument of an invalid type array|string supplied for foreach, only                           
         iterables are supported.                                                                      
  382    Argument of an invalid type array|string supplied for foreach, only                           
         iterables are supported.                                                                      
 ------ ---------------------------------------------------------------------------------------------- 
 ------ ------------------------------------------------------ 
  Line   src/Plugin/Derivative/FieldPropertySourceDeriver.php  
 ------ ------------------------------------------------------ 
  39     Offset string does not exist on array|string.         
 ------ ------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------- 
  Line   src/Plugin/UiPatterns/PropType/AttributesPropType.php                          
 ------ ------------------------------------------------------------------------------- 
  61     Method                                                                         
         Drupal\ui_patterns\Plugin\UiPatterns\PropType\AttributesPropType::normalize()  
         should return array but returns Drupal\Core\Template\Attribute.                
 ------ ------------------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Plugin/UiPatterns/PropType/LinksPropType.php                     
 ------ --------------------------------------------------------------------- 
  73     Cannot access offset 'schema' on                                     
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Plugin/UiPatterns/Source/BlockSource.php                           
 ------ ----------------------------------------------------------------------- 
  209    Cannot access offset 'provider' on                                     
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.    
  225    Method                                                                 
         Drupal\ui_patterns\Plugin\UiPatterns\Source\BlockSource::getBlock()    
         should return Drupal\Core\Block\BlockPluginInterface|null but returns  
         object.                                                                
  276    Cannot access offset '_ui_patterns…' on                                
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.    
 ------ ----------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------------------------------- 
  Line   src/Plugin/UiPatterns/Source/DerivableContextSourceBase.php                                   
 ------ ---------------------------------------------------------------------------------------------- 
  200    Cannot access offset 'value' on 'container'|array{#type: 'container',                         
         #attributes: array{id: string}, #tree: true}|array{#type: 'select',                           
         #title: Drupal\Core\StringTranslation\TranslatableMarkup, #options:                           
         array, #default_value: mixed, #ajax: array{callback:                                          
         array{'Drupal\\ui_patterns\\Plugin\\UiPatterns\\Source\\DerivableContextSourceBase',          
         'onDerivableContextC…'}, wrapper: string, method: 'replace'},                                 
         #executes_submit_callback: false, #empty_value: null, #empty_option:                          
         Drupal\Core\StringTranslation\TranslatableMarkup, ...}|true.                                  
  251    Method                                                                                        
         Drupal\ui_patterns\Plugin\UiPatterns\Source\DerivableContextSourceBase::createSourcePlugin()  
         should return Drupal\ui_patterns\SourceInterface|null but returns                             
         object.                                                                                       
  323    Negated boolean expression is always false.                                                   
         πŸ’‘ Because the type is coming from a PHPDoc, you can turn off this                            
            check by setting treatPhpDocTypesAsCertain: false in your                                  
            phpstan.neon.                                                                              
 ------ ---------------------------------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------- 
  Line   src/Plugin/UiPatterns/Source/FieldPropertySource.php                
 ------ -------------------------------------------------------------------- 
  35     Negated boolean expression is always false.                         
         πŸ’‘ Because the type is coming from a PHPDoc, you can turn off this  
            check by setting treatPhpDocTypesAsCertain: false in your        
            phpstan.neon.                                                    
 ------ -------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------- 
  Line   src/Plugin/UiPatterns/Source/FieldValueSourceBase.php               
 ------ -------------------------------------------------------------------- 
  96     Negated boolean expression is always false.                         
         πŸ’‘ Because the type is coming from a PHPDoc, you can turn off this  
            check by setting treatPhpDocTypesAsCertain: false in your        
            phpstan.neon.                                                    
  105    Expression on left side of ?? is not nullable.                      
 ------ -------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/PropTypeAdapterPluginBase.php                                    
 ------ --------------------------------------------------------------------- 
  19     Cannot access offset 'label' on                                      
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
  26     Cannot access offset 'prop_type' on                                  
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
  33     Cannot access offset 'schema' on                                     
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
 ------ --------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/PropTypeAdapterPluginManager.php                                  
 ------ ---------------------------------------------------------------------- 
  31     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  34     Method                                                                
         Drupal\ui_patterns\PropTypeAdapterPluginManager::guessFromSchema()    
         should return Drupal\ui_patterns\PropTypeAdapterInterface|null but    
         returns object.                                                       
 ------ ---------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/PropTypePluginBase.php                                           
 ------ --------------------------------------------------------------------- 
  20     Cannot access offset 'label' on                                      
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
  34     Cannot access offset 'default_source' on                             
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
  41     Cannot access offset 'schema' on                                     
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
 ------ --------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------------- 
  Line   src/PropTypePluginManager.php                                             
 ------ -------------------------------------------------------------------------- 
  52     Method Drupal\ui_patterns\PropTypePluginManager::guessFromSchema()        
         should return Drupal\ui_patterns\PropTypeInterface|null but returns       
         object.                                                                   
  54     Method Drupal\ui_patterns\PropTypePluginManager::guessFromSchema()        
         should return Drupal\ui_patterns\PropTypeInterface|null but returns       
         object.                                                                   
  77     \Drupal calls should be avoided in classes, use dependency injection      
         instead                                                                   
  167    Right side of && is always true.                                          
         πŸ’‘ Because the type is coming from a PHPDoc, you can turn off this        
            check by setting treatPhpDocTypesAsCertain: false in your              
            phpstan.neon.                                                          
  171    Access to an undefined property object::$data.                            
         πŸ’‘ Learn more:                                                            
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
  190    Left side of && is always true.                                           
         πŸ’‘ Because the type is coming from a PHPDoc, you can turn off this        
            check by setting treatPhpDocTypesAsCertain: false in your              
            phpstan.neon.                                                          
 ------ -------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   src/SourcePluginBase.php                                             
 ------ --------------------------------------------------------------------- 
  180    Cannot access offset 'label' on                                      
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
  198    Cannot access offset 'prop_types' on                                 
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
  361    Cannot access offset 'config_dependencies' on                        
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
 ------ ---------------------------------------------------------------------- 
πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡«πŸ‡·France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024