Contrib.social

Address phpstanissues in pipeline

Open on Drupal.org →
Created on 26 July 2024, about 2 months ago
Updated 14 August 2024, about 1 month ago

Problem/Motivation

During 📌 Update gitlab for future pipelines + address findings Active a number of phpstan were flagged to be fixed later

This is a novice tagged issue and intended for newer users. Also work should be checked so if you're one of those companies that credit farm please leave alone

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

7.0

Component

Miscellaneous

Created by

🇺🇸United States smustgrave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @smustgrave
  • Merge request !35Test → (Merged) created by smustgrave
  • Assigned to smustgrave
  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    To get these moving I'll pick up this one

  • Status changed to Needs review about 2 months ago
  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    Okay this is ready for testing

    Removed functions for getNodeView() as they contained D7 code in some instances so made the assumption they were used.

    Removed some functions in src/Entity/QuizQuestionEntityTrait.php that had D7 code and didn't see being referenced anywhere

    Removed the code for jquery countdown but left a todo that we intend to add something.

    Removed src/EventSubscriber/QuizEventSubscriber.php as it appears to need a replicate module? But didn't see anything mentioning that so assumed it was left over

  • Status changed to Fixed about 2 months ago
  • Comment about 2 months ago →
    🇺🇸United States smustgrave
  • Comment about 1 month ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024