- Issue created by @electrokate
- @electrokate opened merge request.
- πΊπΈUnited States smustgrave
Just fyi for when this gets put up for review all checks need to pass
Phpstsn next major is known issue so can ignore that one
- πΊπΈUnited States electrokate
Ok thanks, I'm still working on the collapsed checkbox feature.
- πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch add-accordion-options to hidden.
- πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch add-accordion-options-squash to hidden.
- πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch 3463627-porting-accordion-options to hidden.
- @smustgrave opened merge request.
- πΊπΈUnited States smustgrave
Rebased but the there a ton of out of scope changes in the plugin js that should be reverted as it also breaks accordions.
- πΊπΈUnited States smustgrave
So I think we can go about this a different route. Instead of through the text formatter lets add 2 new commands to accordion. This way the editors have the power
- Status changed to Needs work
about 1 month ago 4:52pm 12 December 2024 - πΊπΈUnited States electrokate
Hey smustgrave! Thank you so much for rebasing and trying to get this merged. What can I do to help? I am hoping to get it merged so we don't have to add as a patch going forward.
Does this need to be done to merge?
"Instead of through the text formatter lets add 2 new commands to accordion. "If so can you elaborate?
- πΊπΈUnited States smustgrave
Ideally these settings would be attached to the ckeditor plugin so editors can attach per accordion group.
Problem with the text formatter approach is it applies everywhere. So if you don't want certain settings you're stuck.
- πΊπΈUnited States electrokate
Ok thank you. In the meantime, here is a patch with your rebase from 85.diff, which cleanly applies to 3.1.3, in case anyone needs it. (the 85.diff was not applying for me, I just re-compiled the /build/uswds_accordion.js)