Allow Templates without layouts to be nested in a layout at any depth

Open on Drupal.org →

Created on 24 July 2024, 4 months ago

Problem/Motivation

When dropping a template into a layout, if the nesting depth of the current layout (section) exceeds the set nesting depth for that paragraph field then no templates can be added into that layout. However a template can contain only paragraphs and not layouts. Templates that contain only paragraphs (without any layouts) should be allowed to be added to any layout at any depth.

A convenient use case for templates, especially when coupled with style options, is to select pre-defined style options and/or content for a single paragraph and make that a template. If you have a particular paragraph that has many style options available, the number of permutations can quickly grow unwieldy. If some pre-determined configuration set of style options is frequently used by site editors, then it is very convenient to save that set of style options as a template. This allows for easily selecting, with one click, a paragraph with a set of style options that might take many clicks to setup.

In our use case, we only need to define this set of style options for a single paragraph. We need to be able to add a template into a layout at any depth, but only if the template only contains paragraphs without a layout. We still want to respect the nesting depth that is defined for a layout paragraph field as it applies to templates that contain layouts.

Steps to reproduce

Install and setup mercury editor and mercury editor templates
Add paragraphs and setup a content type for use with layout paragraphs and mercury editor
Keep the max nesting depth of the layout paragraph enabled field set to 0 (the default value)
Create a template that only has a paragraph in it, without a layout!
Create a piece of content with the type you setup above
Add a layout. within the layout, add a component: see that your template with only a paragraph isn't available

Proposed resolution

Include the changes found in the attached patch.

The code in the patch checks each template going into the add component dialogue, and if any paragraphs in the template are a section (layout paragraph is enabled) the template is excluded from list of available components to add.
If a template doesn't have any paragraphs with layout paragraphs setup then it is allowed to be added at any depth.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Active

Version

2.1

Component

Code

Created by

🇺🇸United States devanbicher

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!75Allow Templates without layouts to be nested in a layout at any depth
Merged
🇺🇸United States sethhill
updated 18 days ago

Comments & Activities

Issue created by @devanbicher
Comment 4 months ago →
🇺🇸United States devanbicher
Here is my patch to add the above functionality.

Note I am checking that a paragraph is a layout paragraph with the following code:

$behaviors = $paragraph->getAllBehaviorSettings(); $is_layout = isset($behaviors['layout_paragraphs']) && (count($behaviors['layout_paragraphs']) > 2);
If there is a cleaner or preferred way to check that a paragraph is a layout paragraph, please let me know and I can update my patch.
First commit to issue fork.
Merge request !75Issue #3463624: Allow ME templates without layouts to be placed at max nesting depth. → (Merged) created by sethhill
Comment 22 days ago →
🇺🇸United States sethhill
@devanbicher, your patch worked and resolved the issue. I made a slight modification to specifically look for the layout key within the behaviors array, so that if for some reason in the future another element is added into the array it won't cause this to evaluate as true.

$is_layout = isset($behaviors['layout_paragraphs']) && array_key_exists('layout', $behaviors['layout_paragraphs']);
MR!75 makes this change and I've also attached a new patch file. Marking as RTBC.
Comment 22 days ago →
🇺🇸United States sethhill
Pipeline finished with Skipped
18 days ago
#330578

Comment 18 days ago →

sethhill → committed d18d7d20 on 2.1.x

Issue #3463624 by sethhill, devanbicher: Allow Templates without layouts...

Comment 18 days ago →
🇺🇸United States sethhill

Comment 18 days ago →

sethhill → committed d18d7d20 on 2.2.x

Issue #3463624 by sethhill, devanbicher: Allow Templates without layouts...

Comment 4 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024