- Issue created by @godotislate
- Status changed to Needs work
about 1 month ago 6:07pm 26 July 2024 Added change record for deprecation.
Pushed a draft MR with the changes, will add tests later.
Per How to register layouts π Add missing 'label' key to navigation.layouts.yml Active :
The 'label' and 'category' keys are required.
This came up in π Add missing category to Drupal\layout_builder\Plugin\Layout\BlankLayout and let modules and themes alter the list of layouts RTBC and π Add missing 'label' key to navigation.layouts.yml Active . There was a thought to make the two keys required in the annotation to attribute conversion in π Convert Layout plugin discovery to attributes Active , per #2 π Convert Layout plugin discovery to attributes Active and #17 π Convert Layout plugin discovery to attributes Active :
I think we should consider a BC layer where we add a label for unlabelled layouts and trigger a deprecation.
, but then it was kicked back to be done in π Add missing category to Drupal\layout_builder\Plugin\Layout\BlankLayout and let modules and themes alter the list of layouts RTBC , and finally decided to do a separate follow up, which is this issue.
The most direct way to address would be to make the Layout attribute label and category properties required, but some considerations:
Needs work
11.0 π₯
Last updated
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Added change record for deprecation.
Pushed a draft MR with the changes, will add tests later.