Contrib.social

Fix the style for Horizontal line tool in CKeditor5 internal editing preview

Open on Drupal.org →
Created on 23 July 2024, 4 months ago
Updated 5 September 2024, 3 months ago

Problem/Motivation

The horizontal line tool in CKeditor5 is not styled well

Steps to reproduce

Open the layout builder for any page, try to add/edit any block with CKeditor, and then use the horizontal line to observe the style.

Proposed resolution

Add a specific style for the horizontal lines inside the CKEditor only.
#layout-builder-modal .ck.ck-editor hr

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ UX/UI designer responsibilities
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-10.0.1, varbase_layout_builder-10.1.2 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

10.1

Component

Code

Created by

🇯🇴Jordan n.ghunaim Amman - Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Pipeline finished with Success
    4 months ago
    Total: 228s
    #222085
  • Pipeline finished with Failed
    4 months ago
    Total: 284s
    #222090
  • Pipeline finished with Success
    4 months ago
    Total: 258s
    #222098
  • Issue created by @n.ghunaim
  • Merge request !65Issue #3463312 by n.ghunaim: Fix the style for Horizontal line tool in CKeditor5 internal editing preview → (Merged) created by n.ghunaim
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇯🇴Jordan n.ghunaim Amman - Jordan
  • Comment 4 months ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Pipeline finished with Success
    4 months ago
    Total: 169s
    #239898
  • Pipeline finished with Success
    4 months ago
    #245210
  • Pipeline finished with Failed
    4 months ago
    Total: 968s
    #245250
  • Pipeline finished with Failed
    4 months ago
    Total: 1140s
    #245311
  • Pipeline finished with Canceled
    3 months ago
    Total: 576s
    #251975
  • Pipeline finished with Canceled
    3 months ago
    Total: 447s
    #251984
  • Pipeline finished with Canceled
    3 months ago
    Total: 348s
    #251989
  • Pipeline finished with Failed
    3 months ago
    Total: 1025s
    #251995
  • Pipeline finished with Success
    3 months ago
    #252007
  • Pipeline finished with Success
    3 months ago
    Total: 377s
    #252011
  • Pipeline finished with Failed
    3 months ago
    Total: 986s
    #252114
  • Pipeline finished with Failed
    3 months ago
    Total: 1106s
    #252240
  • Pipeline finished with Failed
    3 months ago
    Total: 1082s
    #252412
  • Pipeline finished with Failed
    3 months ago
    Total: 976s
    #253092
  • Pipeline finished with Failed
    3 months ago
    #253107
  • Pipeline finished with Failed
    3 months ago
    Total: 1313s
    #253177
  • Pipeline finished with Failed
    3 months ago
    Total: 1052s
    #253250
  • Pipeline finished with Failed
    3 months ago
    Total: 1272s
    #253266
  • Pipeline finished with Failed
    3 months ago
    Total: 1963s
    #253321
  • Pipeline finished with Canceled
    3 months ago
    Total: 570s
    #253336
  • Pipeline finished with Success
    3 months ago
    Total: 1107s
    #253339
  • Pipeline finished with Failed
    3 months ago
    Total: 117s
    #256200
  • Pipeline finished with Success
    3 months ago
    Total: 113s
    #256226
  • Pipeline finished with Success
    3 months ago
    Total: 624s
    #256275
  • Pipeline finished with Success
    3 months ago
    Total: 113s
    #257189
  • Pipeline finished with Success
    3 months ago
    Total: 114s
    #257215
  • Pipeline finished with Failed
    3 months ago
    Total: 117s
    #257315
  • Pipeline finished with Failed
    3 months ago
    Total: 1059s
    #257419
  • Pipeline finished with Failed
    3 months ago
    #257433
  • Pipeline finished with Success
    3 months ago
    Total: 205s
    #257439
  • Pipeline finished with Success
    3 months ago
    #258005
  • Pipeline finished with Success
    3 months ago
    #258040
  • Pipeline finished with Success
    3 months ago
    Total: 144s
    #258051
  • Comment 3 months ago →
    System Message
  • Status changed to Fixed 3 months ago
  • Comment 3 months ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment 3 months ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Pipeline finished with Success
    3 months ago
    Total: 212s
    #271068
  • Pipeline finished with Success
    3 months ago
    Total: 205s
    #271185
  • Pipeline finished with Success
    3 months ago
    Total: 527s
    #271347
  • Comment 3 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    2 months ago
    Total: 212s
    #279396
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024